Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIFF: fix header writing for big-endian BigTIFF files #258

Merged
merged 1 commit into from Dec 4, 2012

Conversation

melissalinkert
Copy link
Member

@bpindelski
Copy link

  1. Merged ok locally into bioformats/dev_4_4
  2. Executed ant clean jars tools
  3. Used tools/bfconvert -bigtiff CFPNEAT01_R3D.dv foo.tif
  4. Opened foo.tif using Hex Fiend
  5. First 8 bytes read: 4D 4D 00 2A 00 08 00 08

Seems to be fixed and ready to merge...

@bpindelski
Copy link

Second round of testing, after discovering that an old version of BF-tools was on the PATH. Additionally, the tested DV file was little-endian, so not fit for this test. Previous comment can be disregarded.

This time an ariol image was used and bfconvert used: ./bfconvert -bigtiff ~/Desktop/testing/import/ariol/04CBE9A7-FA1B-4556-9900-6D869E85FFC7.jpg foo.tif. The first 8 bytes of the header read: 4D 4D 00 2B 00 08 00 00, as expected.

@joshmoore
Copy link
Member

@melissalinkert, should this have been run against any data tests via --test ?

@melissalinkert
Copy link
Member Author

@joshmoore, no, --test only runs reader tests, and this is a writer-only change.

@joshmoore
Copy link
Member

Doh. That's going to keep driving me nuts. It's a reflex.

joshmoore added a commit that referenced this pull request Dec 4, 2012
TIFF: fix header writing for big-endian BigTIFF files
@joshmoore joshmoore merged commit bec1c53 into ome:dev_4_4 Dec 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants