Writer tests #297
Merged
Writer tests #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These do not operate on real data (rather a small generated image and minimal metadata), but provide fairly comprehensive coverage of all writers. The 'test-minimal-convert' Ant target can be used to run the tests. See #9402.
Noticed by the writer tests.
Noticed by the writer tests.
Noticed by the writer tests.
| @@ -1468,6 +1468,11 @@ else if (labels.equalsIgnoreCase("x y t")) { | |||
|
|
|||
| for (int i=0; i<pixelSizes.length; i++) { | |||
| Double pixelSize = pixelSizes[i]; | |||
|
|
|||
|
Yep, probably makes sense to backport all of this to dev_4_4 once there are no objections to the actual changes. It's on develop because optimistic me thought this would only be new tests, not tests and bug fixes. |
|
😄 Well that answered my next question. |
|
This all looks ok and the hudson job runs fine in terms of space/time restrictions. Looks good to merge. |
|
Merging Thursday evening (and then backporting to dev_4_4). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket #9402 and the BIOFORMATS-writers Jenkins job.
1 test failure is expected for now, since PRs #246 and #265 are not on develop yet.