Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deltavision: parse more key/value pairs from the log file #2974

Merged
merged 1 commit into from Nov 20, 2017

Conversation

melissalinkert
Copy link
Member

Fixes https://trac.openmicroscopy.org/ome/ticket/13237

To test, use the dataset in data_repo/curated/deltavision/michael/ticket-13237/. This was created by copying data_repo/curated/deltavision/michael/mtools/CTR_centrosome_01_R3D.dv to 01_R3D.dv and placing 01_R3D.dv.log from the ticket attachment in the same directory.

Comparing showinf -nopix 01_R3D.dv with and without this change should show that there are more original metadata key/value pairs with this change. The log file lines noted on the ticket should be represented by original metadata with this change. There should be no difference in pixel data or image dimensions.

Copy link
Member

@mtbc mtbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resulting changes are,

13c13
< Initialization took 0.633s
---
> Initialization took 0.644s
48a49
> CHANNEL: 0.1000,FITC,FITC,100%
53a55,65
> DURATION: 0.100000
> EM_SHUTTERS: 1,CCD1=F
> ENTIRE_EXP_REPEATS: 1
> EVENT_BLEACH: PATTERN
> EVENT_MOTION_OPTIMIZE: POSITION
> EVENT_REPEATS: 5
> EVENT_TIME_MARK: END
> EXPECTED_HALFTIME: 1.000
> EXPERIMENT_TYPE: PK
> EXP_REPEATS_TIMELAPSE: 10.000
> EX_SHUTTERS: 3,EX=T,TRANS=F,LASER=F
404,408c416,420
< Image Properties Binning: 1x1
< Image Properties Flat-field Calibration: Off
< Image Properties Pixel Size: 0.16000 0.16000 0.200
< Image Properties XY Dimensions: 512 x 512
< Image Properties ZWT Dimensions (expected): 1 x 1 x 35
---
> Image Properties: Binning: 1x1
> Image Properties: Flat-field Calibration: Off
> Image Properties: Pixel Size: 0.16000 0.16000 0.200
> Image Properties: XY Dimensions: 512 x 512
> Image Properties: ZWT Dimensions (expected): 1 x 1 x 35
412a425,426
> LASER_CHANNEL: 406
> Laser Event Locations (x,y):           47.36, 47.52 (spot)
421a436,438
> POST_EVENT_IMAGES: 32
> PRE_EVENT_IMAGES: 3
> PRE_IMAGE_TIME_INTERVAL: 0.500
464a482,486
> QLM Bleach Event Points #1:   SPOT 45.62 45.39
> QLM Bleach Event Points #2:   SPOT 43.55 42.95
> QLM Bleach Event Points #3:   SPOT 41.49 40.50
> QLM Bleach Event Points #4:   SPOT 39.43 38.06
> QLM Bleach Event Points #5:   SPOT 47.36 47.52
465a488,489
> QLM Settings for PhotoKinetics Experiment #1:      Laser 406 nm, Power 20.00(%), 4.00(mW), Duration 0.1000
> QLM Settings for PhotoKinetics Experiment #2:      Beam Expander Position 0, Laser Spot Radius 0.00 um
466a491,494
> Resolve3D Macro #1: OPF
> Resolve3D Macro #2: SCANPK 0.100000,1,0,3,1,2,0,0,1,-1.000,0.100000,1,3,5,3,32,1.000,120.000,4,1,0.500,1,0.000
> Resolve3D Macro #3: CLF
> Resolve3D Macro #4: BEEP
475a504
> TIME_COURSE_STYLE: AUTO

@sbesson sbesson added this to the 5.7.2 milestone Oct 23, 2017
@dgault
Copy link
Member

dgault commented Nov 20, 2017

Merging the PR as all additions to the global meta look good and remaining metadata is unchanged.

@dgault dgault merged commit dcefe24 into ome:develop Nov 20, 2017
@melissalinkert melissalinkert deleted the dv-laser branch July 11, 2018 15:51
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-and-omx-v4-omx-sr-metadata/40140/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants