Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSI: Add support for Lossless JPEG #3036

Merged
merged 2 commits into from Jan 23, 2018
Merged

Conversation

dgault
Copy link
Member

@dgault dgault commented Jan 10, 2018

This PR is in relation to https://www.openmicroscopy.org/community/viewtopic.php?t=8425&p=18953
The associated Trello card is https://trello.com/c/fUhH0Cxo/141-cellsens-vsi-npe-in-openbytes

Sample files can be found in QA-18870 and QA-17728

The issue was caused by an unknown compression type of value 5. From the user feedback this has been identified as Lossless JPEG. This PR adds support using the existing LosslessJPEG codec.

To test:

  • All builds and tests should remain green
  • With this PR opening QA-18870 should result in a NullPointerException
  • With this PR opening QA-18870 should display the images correctly without error

@dgault dgault added this to the 5.8.0 milestone Jan 10, 2018
@dgault
Copy link
Member Author

dgault commented Jan 22, 2018

The last commit is not related to the initial description of the PR but is needed to prevent failures with adding the associated config to the data repo (https://github.com/openmicroscopy/data_repo_config/pull/256).

The failure were due to the pyramids arraylist not being cleared when the reader is closed.

@sbesson
Copy link
Member

sbesson commented Jan 23, 2018

With the last commit, all automated tests have been successfully running against the cellsens folder and the failures reported in #3036 (comment) when testing multiple CellSens filesets while recycling the ImageReader are gone. Merging.

@sbesson sbesson merged commit 90a242a into ome:develop Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants