Micromanager: switch to DataTools.parseDouble for double parsing #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automatically prevents NumberFormatExceptions for invalid double values and handles the case when the decimal separator in the file doesn't match the current locale's decimal separator.
|
Closing/reopening to include #3251 |
sbesson
reviewed
Oct 25, 2018
| } | ||
| catch (NumberFormatException e) { } | ||
| } | ||
| else if (key.equals("YPositionUm")) { | ||
| try { | ||
| Position p = positions.get(getCoreIndex()); | ||
| p.positions[i][1] = new Double(value); | ||
| p.positions[i][1] = DataTools.parseDouble(value); | ||
| } | ||
| catch (NumberFormatException e) { } |
There was a problem hiding this comment.
With the usage of the DataTools API, could we further simplify this code and remove the NumberFormatException handling in the reader?
DataTools.parseDouble should catch NumberFormatException internally.
|
This change looks good and has no negative impact on existing datasets. Tested by modifying existing datasets to produce the PR is good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from a private PR.
This automatically prevents
NumberFormatExceptions for invalid double values and handles the case when the decimal separator in the file doesn't match the current locale's decimal separator.To test, use
curated/micromanager/pr-3253, which was copied fromcurated/micromanager/qa-4984/, but with0.5,replaced by"0,5",inmetadata.txt. Without this PR,showinf -nopix -omexml metadata.txtwill throw:With this PR, the same test should successfully initialize the file and display OME-XML with
PhysicalSizeXandPhysicalSizeYset to0.5.Builds and memo files should not be impacted.