Sprint 4 bug fixes, part 2 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported by Marc Lartaud.
When a writer is 'closed', the current ifdCounts map has all present entries reset to 0. This map is referenced in populateImage, but if you change output files (multi-file dataset), the stored IFD count is used to populate the TiffData elements in each series. Each subsequent file would cause the old TiffData IFDs to be replaced with a new sequence beginning at the old maximum. Also, the IFDs for series 0 were being reduced by 1. This caused each IFD in series 0 to be identical. Signed-off-by: Luke Stuyvenberg <stuyvenberg@wisc.edu>
The global minimum and maximum values are only available if every plane in the series has been read. In some cases (e.g. if "Specify range..." was specified), we need autoscaled images but have not read all of the planes. Fixes #10088.
Fixes #10092.
Reported by Nicolas Brouilly.
|
--test tiff |
Fixes QA #4832/#4833.
|
--test leica-tcs That's the last of the fixes that I intended to add to this PR, so it's now ready for review. |
This is what 49a3ec6 should have done.
|
Looks fine, builds fine. I can't see that hudson ran the commit tests though, it looks like it failed to start the job properly. |
|
I had to remove a bunch of jobs from the queue this morning (nearly everything that was scheduled to run Sunday night), as BIOFORMATS-per-commit-test build 257 got stuck and was holding everything up. Everything should be back to green Monday evening/Tuesday morning. |
|
I've run all four of the above tests by hand in the meantime. Zero failures, so should be OK to merge. |
|
Merging Tuesday afternoon, assuming |
melissalinkert
added a commit
that referenced
this pull request
Jan 15, 2013
Sprint 4 bug fixes, part 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add a few more commits here, but am opening the PR now in order to respond to email/forum posts.
Fixes for tickets #10040 and #10088 will be added in the next couple of days.