Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve error for big .fli files #3303

Merged
merged 1 commit into from Jan 21, 2019
Merged

Solve error for big .fli files #3303

merged 1 commit into from Jan 21, 2019

Conversation

rharkes
Copy link
Contributor

@rharkes rharkes commented Jan 14, 2019

Big files gave an integer overflow on line 191.

Big files gave an integer overflow on line 191.
@rharkes rharkes changed the title Solve error for big files Solve error for big .fli files Jan 14, 2019
@sbesson
Copy link
Member

sbesson commented Jan 14, 2019

Thanks @rharkes. Including the changes for the daily CI builds. We do not have any representative .fli file that shows such an integer overflow. Would you have one you would be able to share with us so that we could add it to our non-regression tests?

@rharkes
Copy link
Contributor Author

rharkes commented Jan 14, 2019

@sbesson Yes I have one, but it is 2.3 GB in size, since the problem does not occur below 2GB.

@melissalinkert
Copy link
Member

@rharkes: alternate instructions for sending large files have been sent to you via private email.

@melissalinkert
Copy link
Member

Thank you for uploading sample files, @rharkes.

@openmicroscopy/formats, files copied to inbox/gh-3303/ for testing.

@dgault dgault added this to the 6.0.0 milestone Jan 21, 2019
@dgault
Copy link
Member

dgault commented Jan 21, 2019

In this particular case the Integer overflow is being caused by the large number of timepoints as opposed to the bytes per plane. As such the change makes sense and other instances of plane size do not need to be updated.

I tested using the large sample file provided.

Without the PR opening the image and reading one of the later timepoints results in:
java.lang.IllegalArgumentException: Negative position

With the PR included I was able to open and read all of the planes within the image without issue.

This is good for inclusion in Bio-Formats 6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants