Build fixes for the imglib2 dependency #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The T method parameter caused a compile error against the retrotranslated imglib2. Using a RealType<?> avoids it.
This release is a specially crafted, retrotranslated version of the JAR that should work with Java 1.5 (though Jenkins will tell us for sure).
melissalinkert
added a commit
that referenced
this pull request
Mar 23, 2012
Build fixes for the imglib2 dependency
melissalinkert
pushed a commit
to melissalinkert/bioformats
that referenced
this pull request
Jan 11, 2018
Add MetaXpress support on mainline_5_1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch hopefully fixes all the imglib2-related problems when building. It covers both the Ant- and Maven-based build systems.
It works by adding an imglib2.jar to the repository, which has been retrotranslated to work in Java 1.4+. This special version of imglib2 has also been deployed to our Maven repository as release version 20120321. Using this version also happens to avoid problems with the very latest imglib2 changing some API that resulted in additional build failures. In the future, we will need to bring the ome.scifio.img package into sync with these changes, but for now all should be well!