Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export of multiple files #470

Merged
merged 3 commits into from Apr 24, 2013
Merged

Conversation

melissalinkert
Copy link
Member

See https://trac.openmicroscopy.org.uk/ome/ticket/10635

This needs manual testing, ideally both in ImageJ and using bfconvert. All stack output formats (OME-TIFF, TIFF, QuickTime, AVI, PNG, ICS) are affected; readers are not affected at all.

In ImageJ, best would be to test opening a single dataset with SizeZ, SizeC, and SizeT all greater than 1, then exporting to each of the above formats with one or more of the "Write each ..." boxes checked. No error message should be shown, and the converted files should all open correctly.

With bfconvert, just testing that bfconvert input-file output-file works for each of the above output formats should be enough.

@ghost
Copy link

ghost commented Apr 23, 2013

Export of avi split by c+t ran out of file handles Over 10000 open after doing a few exports of different formats (1400 planes/image). Possible leak?

See https://gist.github.com/rleigh-dundee/5445697

Screen shot 2013-04-23 at 18 21 08 (Ran out of filehandles for copying it!)

@ghost
Copy link

ghost commented Apr 23, 2013

Export of multiple images works correctly for both bfconvert and imagej. OME-TIFF tested for all possible combinations of splitting, and all reimport correctly. However, all writers appear to leave all filehandles open.

@melissalinkert
Copy link
Member Author

Open file handle issues should be fixed now.

Only other issue I know of in connection with this PR was with /ome/team/rleigh/ics-test.zip. In checking, the reported behavior (picking any file with "Group files with similar names" checked only opens one timepoint) is correct, or at least expected. Each timepoint consists of multiple files, presumably because the .ids extension was used when converting. File grouping is disabled when the dataset already has multiple files; exporting with the .ics extension instead would solve the problem.

@ghost
Copy link

ghost commented Apr 24, 2013

No file handle leaking now observed (testing with FiJi). Please merge.

joshmoore added a commit that referenced this pull request Apr 24, 2013
@joshmoore joshmoore merged commit e91a21b into ome:dev_4_4 Apr 24, 2013
hflynn added a commit to hflynn/bioformats that referenced this pull request Oct 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants