Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bfGetReader for MATLAB R2009a and earlier #688

Merged
merged 5 commits into from Sep 9, 2013

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Sep 5, 2013

Following the http://lists.openmicroscopy.org.uk/pipermail/ome-users/2013-September/003912.html and http://lists.openmicroscopy.org.uk/pipermail/ome-users/2013-September/003910.html threads, this pull request patches the bfGetReader.m function to allow it to be used with Matlab versions earlier than R2009b.

As a first implementation of this patch, the version check is performed using Matlab built-in verLessThan function available with MATLAB Version 7.4 and subsequent versions rather than using/maintaining the versionCheck() sub-function.

Such an implementation of the version check practically means we would drop support for versions of MATLAB earlier than 7.4 (R2007a). Consequently the typecasting workaround in bfGetPlane for earlier versions of Matlab than 7.1 is also dropped as part of this PR.

We may also want to expose a minimal version in the documentation page /cc @hflynn


--rebased-to #693

@sbesson
Copy link
Member Author

sbesson commented Sep 5, 2013

Looking further, the minimal Matlab version bundling JVM 1.6 or later is R2007b (7.5). With the changes merged in #653 setting JDK 1.6 as the minimum supported version, maybe this set R2007b as the minimal supported version /cc @rleigh-dundee

@ghost
Copy link

ghost commented Sep 6, 2013

The minimum version change looks sensible.

@hflynn
Copy link
Member

hflynn commented Sep 6, 2013

👍 to minimum version doc update - do you want to add a note to the developer page for Matlab as well, just incase people skip the user page?

@sbesson
Copy link
Member Author

sbesson commented Sep 6, 2013

Done

@hflynn
Copy link
Member

hflynn commented Sep 9, 2013

Good to merge as far as I'm concerned, thanks for those extra changes.

melissalinkert added a commit that referenced this pull request Sep 9, 2013
Fix bfGetReader for MATLAB R2009a and earlier
@melissalinkert melissalinkert merged commit 093d067 into ome:dev_4_4 Sep 9, 2013
@sbesson
Copy link
Member Author

sbesson commented Sep 9, 2013

--rebased-to #693

@sbesson sbesson mentioned this pull request Sep 9, 2013
10 tasks
@sbesson sbesson deleted the matlab_versioncheck branch September 9, 2013 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants