New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bfGetReader for MATLAB R2009a and earlier #688
Conversation
Looking further, the minimal Matlab version bundling JVM 1.6 or later is R2007b (7.5). With the changes merged in #653 setting JDK 1.6 as the minimum supported version, maybe this set R2007b as the minimal supported version /cc @rleigh-dundee |
The minimum version change looks sensible. |
👍 to minimum version doc update - do you want to add a note to the developer page for Matlab as well, just incase people skip the user page? |
Done |
Good to merge as far as I'm concerned, thanks for those extra changes. |
Fix bfGetReader for MATLAB R2009a and earlier
--rebased-to #693 |
Following the http://lists.openmicroscopy.org.uk/pipermail/ome-users/2013-September/003912.html and http://lists.openmicroscopy.org.uk/pipermail/ome-users/2013-September/003910.html threads, this pull request patches the
bfGetReader.m
function to allow it to be used with Matlab versions earlier than R2009b.As a first implementation of this patch, the version check is performed using Matlab built-in
verLessThan
function available with MATLAB Version 7.4 and subsequent versions rather than using/maintaining theversionCheck()
sub-function.Such an implementation of the version check practically means we would drop support for versions of MATLAB earlier than 7.4 (R2007a). Consequently the typecasting workaround in
bfGetPlane
for earlier versions of Matlab than 7.1 is also dropped as part of this PR.We may also want to expose a minimal version in the documentation page /cc @hflynn
--rebased-to #693