ImageConverter: fix dimensions of the last tile

[melissalinkert]

Suggested by Kristian Kjaergaard on the ome-users mailing list:

http://lists.openmicroscopy.org.uk/pipermail/ome-users/2013-September/003940.html

If the width (or height) of the image is evenly divisible by the tile width (or height), the previous behavior was to set the width (or height) of the last tile to be converted to 0.

[joshmoore]

@melissalinkert : is this something a unit test could be added for?

[melissalinkert]

Definitely worth adding a unit test during the course of http://trac.openmicroscopy.org.uk/ome/ticket/10517

[joshmoore]

Comment added to 10517

[qidane]

Still not tested, I am still getting this error:

[andrew@voile tools ((f93cb07...))]$ ./bfconvert ~/Desktop/4097.psd ~/Desktop/4097.ome.tiff
/Users/andrew/Desktop/4097.psd
[Adobe Photoshop] -> /Users/andrew/Desktop/4097.ome.tiff [OME-TIFF]
Exception in thread "main" loci.formats.FormatException: Image plane too large. Only 2GB of data can be extracted at one time. You can workaround the problem by opening the plane in tiles; for further details, see: http://www.openmicroscopy.org/site/support/faq/bio-formats/i-see-an-outofmemory-or-negativearraysize-error-message-when-attempting-to-open-an-svs-or-jpeg-2000-file.-what-does-this-mean
at loci.formats.FormatReader.openBytes(FormatReader.java:774)
at loci.formats.ImageReader.openBytes(ImageReader.java:400)
at loci.formats.tools.ImageConverter.convertTilePlane(ImageConverter.java:575)
at loci.formats.tools.ImageConverter.convertPlane(ImageConverter.java:535)
at loci.formats.tools.ImageConverter.testConvert(ImageConverter.java:481)
at loci.formats.tools.ImageConverter.main(ImageConverter.java:667)
Caused by: java.lang.IllegalArgumentException: Invalid array size: 0 x 85 x 3 x 1
at loci.common.DataTools.safeMultiply32(DataTools.java:883)
at loci.common.DataTools.allocate(DataTools.java:862)
at loci.formats.FormatReader.openBytes(FormatReader.java:771)
... 5 more

[qidane]

OK, I am stupid! When I downloaded the new jar I saved it in the same folder as an old one, and the new one was auto-renamed. I then was testing with the old one again. It works with the right new jar.

[melissalinkert]

Merging Wednesday unless any further objections then. It would be best to have this in 4.4.9, especially since it was mentioned on the mailing list: http://lists.openmicroscopy.org.uk/pipermail/ome-users/2013-September/003954.html

[melissalinkert]

--rebased-to #722