C++: Add FormatReader implementation #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
March 12, 2014 20:38
While not const in reality, these are treatedly as effectively const in order to allow for their use in const methods.
For use by any class implementing FormatReader, with methods which need to modify reader series/index state.
While originally defined in CoreMetadata, these are used by many different classes, so it makes sense to split them out.
ghost
added
the
|
Still needs copyright headers fixing. |
|
Fixing the headers is next on my list. |
|
Code looks plausible. |
|
Is there anything preventing this being merged? |
melissalinkert
added a commit
that referenced
this pull request
Mar 25, 2014
C++: Add FormatReader implementation
|
--no-rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the main FormatReader implementation (detail/FormatReader) and associated helper classes.
Note that a couple of bits of functionality are missing since the bits they depend on are not yet available. These are marked with
@todoin the sources.Some of the FormatReader/FormatHandler interface logic wasn't quite correct, and this has been fixed in this PR. Primarily constness and type fixes.