New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OME model jobs to the devspace stack #59
Conversation
Add two more jobs preceding the Bio-Formats build for merging all PRs opened against ome-model and building the JARs using Maven.
4a950cf
to
30b8df0
Compare
Currently tested in the context of ome/ome-model#14. With the corresponding branches allowing to couple the various versions, a low-level model PR can be propagated up the stack to the OMERO build for investigation. One interesting side issue is that the Bio-Formats Ant build currently needs to be disabled as it cannot access the JAR built by the model jobs. I see two possible ways:
|
No immediate objections to sharing .m2 across the containers. We'll just need to put some thought into not having 2 jobs write the same sub-directories at the same time. However, that being said, I don't necessarily see an advantage in having a |
At least at the level of Bio-Formats, having Ant and Maven writing concurrently into the same shared directory is known to cause corruption. The On the other side, while the |
For testing model based PRs, separate containers cannot work without sharing the Maven repository. As the only requirement in the baseslave container is Findbugs, the installation is added to the Dockerfile and the Ant job is migrated on this container.
Note the latter commit should implement #59 (comment), was successfully deployed on the transforms devspace and restored the success of the BIOFORMATS-ant. As noted above, if accepted, this proposal should likely constitue a |
For some unkown reason we are back to the encoding issue that I thought #7 had fixed. Using either this branch of the last tag of devspace:
|
Closing for now as this conflicts with the |
For the upcoming testing of the transform code-generation work.
This PR:
bf
slave in favor of the generictestintegration
for running all Java related build jobsDockerfile
as required by the Bio-Formats job