Fixing ticket 10174

[hflynn]

No description provided.

[mtbc]

It seems to default to false to me when I run unit tests. Inspection of lifecycle.xml reveals a few,

<property name="test.with.fail" value="false"/>

so it won't actually default to true in quite the cases that the reader may expect.

[joshmoore]

@mtbc, are you referring to all of the items which are proceeded with:

<!-- may be overriden by fail-on-error -->

? If so, the top-level setting to true in globals.xml should take precedence. (If anything we now need a dont-fail-on-error target to prevent that behavior.)

Can you give a specific example which defaults to false?

[mtbc]

./build.py test-unit is much faster with -Dtest.with.fail=true and ends differently, and takes the same length of time and ends at the same place with -Dtest.with.fail=false.

[hflynn]

Any verdict on this? Happy to change it if someone gives me alternative text to use.

[mtbc]

If @joshmoore thinks the text is probably correct I'm fine with merging it now and our looking again at the situation another time. Even if it's misleading about the default for our builds, it may still be an overall improvement in pointing out that it's an ant property and what it's for: it's not like the consequences of wrongly thinking that it defaults to true are severe.

[joshmoore]

@mtbc, my apologies, I found the reason. etc/local.properties.example (which sets the defaults) has the value specified:

  5 ############################################
  4 # Testing
  3 ############################################
  2 #
  1 # Prevents test failures from stopping the build
  0 test.with.fail=false

In order to not change functionality, let's use false then in the docs, and I'll add a clean-up of this situation to one of my open build branches.

[mtbc]

Great, so it's presently false by default, only a small change needed to this PR.

I had noticed that file but it hadn't occurred to me that a file named *.example might actually be used for configuration, I thought it was, well, just an example of how to do it!

[hflynn]

Better now?

[hflynn]

3rd time lucky?

[mtbc]

You probably don't need the example line with -Dtest.with.fail=false but, yes, either way I'm happy, good to merge. (-: (My 'including' was a poor choice of verb.)

[joshmoore]

(No complaints here)

[hflynn]

I'll rebase to develop as is then shall I?

[mtbc]

Sure, go ahead.

[gusferguson]

Checked on:
https://www.openmicroscopy.org/site/support/omero4-develop/developers/Development/OmeroDevelopment.html

• text appears as intended.