Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose OMERO_HOME in the doc (see #10603) #310

Merged
merged 6 commits into from Apr 9, 2013
Merged

Do not expose OMERO_HOME in the doc (see #10603) #310

merged 6 commits into from Apr 9, 2013

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 29, 2013

OMERO_HOME is an internal variable used in bin/omero and should not be set unless people really know what they are doing.

This PR replaces all occurrences of OMERO_HOME by either

  • OMERO_PREFIX when pointing at a OMERO.server instance
  • OMERO_SOURCE_PREFIX when pointing at the source code root directory

mtbc
mtbc reviewed Apr 1, 2013
View reviewed changes
sysadmins/unix/server-install-linux.txt
@@ -151,8 +151,8 @@ a release version of OMERO.server, extract it from the zip archive:

$ unzip OMERO.server-|release|-ice33-byy.zip

Give your OMERO software install a nice local name to save some typing
later, to reflect what you set :envvar:`OMERO_HOME` to, and to make it easy to
Give your OMERO software install a nice local name to save some typinglater,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"typing later"

@mtbc
Copy link
Member

mtbc commented Apr 1, 2013

Well, at least the system still seems to build and run just fine without OMERO_HOME set.

mtbc
mtbc reviewed Apr 1, 2013
View reviewed changes
sysadmins/unix/server-install-linux.txt
~/apps/OMERO/OMERO.server

If you change the location that you wish to install OMERO to, then you will
also have to alter your :envvar:`OMERO_PREFIX` environment variable to reflect
this.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Surely it only has any effect if one also sets the variables that depend upon it in the other export statements?

@sbesson
Copy link
Member Author

sbesson commented Apr 1, 2013

@mtbc: I tried to move this paragraph down so that it would not refer to OMERO_PREFIX before the variable definition. After re-reading, 1- from the configuration block, it is intuitive that OMERO_PREFIX affects the other environment variables and 2- we already suggest symlinking the server directory to minimise configuration modifications during upgrades.
For all these reasons, I removed the small paragraph in 4c16c77.

@mtbc
Copy link
Member

mtbc commented Apr 2, 2013

Good to merge.

@joshmoore
Copy link
Member

Any further comments on deprecating/removing the special OMERO_HOME case? @chris-allan?

@chris-allan
Copy link
Member

Not setting OMERO_HOME explicitly in the environment is all I'm personally concerned about so no, no further comments.

@joshmoore
Copy link
Member

Ok. Merging for now. I'm happy to discuss elsewhere dropping my (lovely) OMERO_HOME though.

joshmoore added a commit that referenced this pull request Apr 9, 2013
@joshmoore
Merge pull request #310 from sbesson/10603_omerohome_envvar
f4bdf2b 
Do not expose OMERO_HOME in the doc (see #10603)
@joshmoore joshmoore merged commit f4bdf2b into ome:dev_4_4 Apr 9, 2013
@sbesson sbesson deleted the 10603_omerohome_envvar branch April 9, 2013 10:12
@sbesson sbesson mentioned this pull request Apr 9, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev_4_4
Projects
None yet
Milestone
4.4.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbesson @mtbc @joshmoore @chris-allan