-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Training update april 13 1 #346
Conversation
Patch size is 2.4MB ( |
@joshmoore |
We have talked about moving them to squig with @jburel but I don't know what is required to actually get this done. I guess the question is, can we put this off until after Paris or does it need sorting sooner than that? |
Changes all look very minor to me - for consistencies sake rather than actually changing any steps in the guides so we could hold off and move the images first. What do you want to do @joshmoore ? |
@hflynn |
@gusferguson: are all of the images somewhere on necromancer? If so, we could attempt to modify the jobs to use those files. |
/cc @sbesson |
@joshmoore: although I like the idea of hosting images on necromancer and not have them under version control, I tried the following test:
When compiling the HTML with the default Jenkins options
If no Two potential solutions I can think of if we want to host images on necromancer would be:
See also this thread |
The images (and the rest of my docs) are just backed up on squig at the moment. |
I like either of your suggestions, but I was definitely thinking more of the former, in which when building on necromancer, the files would just be in the "right place". |
Note: ongoing discussion in google doc on how best to address this. |
Decision has been made to hold off moving images until after Paris so we don't risk breaking things or make ourselves any busier than we are already. Can we get this merged then please so @gusferguson doesn't have a big backlog of version differences to deal with? |
Understood. Merging. |
--no-rebase |
Updates to screenshots in getting-started.txt, managing-data.txt, viewing-data.txt and scripts.txt. Adding orphaned images to Insight, new import window and other minor changes.