Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to add FS import to developer docs #375

Merged
merged 7 commits into from May 30, 2013
Merged

Conversation

hflynn
Copy link
Member

@hflynn hflynn commented May 24, 2013

See ticket https://trac.openmicroscopy.org.uk/ome/ticket/10931 - this adds content from https://docs.google.com/document/d/15zpLHsXhvSbCa5hLIn9Mwj3spCq-2wvN9QXLZCao3ZU/edit# to the sphinx docs ready for updating & tidying. Some sections are still be added to FSlite.txt but this PR is intended to review current content and structure before the rest is filled in in later PRs.

server, this will be the only repository. Need not be located under
``omero.data.dir`` but is by default.

- ``omero.fslite.path`` - the so-called “template” which will be pre-pended to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about "so-called" here. It is a template and it determines the path that is pre-prended. I.e.the template itself is not pre-prended.

@ximenesuk
Copy link
Contributor

This all looks a good first step, accepting @joshmoore and @jburel's comments. I appreciate that a lot of this is work in progress so I don't know whether we want to amend and continue working on this PR or get this merged and then continue to fix after that?

@hflynn
Copy link
Member Author

hflynn commented May 29, 2013

How about I fix the few minor issues (OR, sha1 etc) and then we get this merged? Probably easier for you to do another PR when you are ready rather than doubling our effort by you making comments & me fixing stuff.

@ximenesuk
Copy link
Contributor

Sounds good. Some of the other issues will probably need revising as things develop anyhow.

@hflynn
Copy link
Member Author

hflynn commented May 29, 2013

Right, this should be ok for now. I've rephrased the sentence about filesets but probably we'll want to add a link there to the output of https://trac.openmicroscopy.org.uk/ome/ticket/10793 once it exists.

@ximenesuk
Copy link
Contributor

@hflynn Thanks for the changes. Looks good for merging now.

joshmoore added a commit that referenced this pull request May 30, 2013
Initial work to add FS import to developer docs
@joshmoore joshmoore merged commit ba793fd into ome:develop May 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants