Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Americanize spellings, fix typos, expand contractions (rebased) #406

Merged
merged 6 commits into from Jul 4, 2013

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented Jul 2, 2013

rebases #390

@@ -90,9 +90,9 @@ OMERO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the Removed is displayed with stars whereas Deprecated only with bold uppercase. Maybe this is intended.
screen shot 2013-07-03 at 14 20 59

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is; I honestly don't know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: on the plone news announcement pages the extra set of stars makes REMOVED bold AND italics, which is why it's been used I would guess. This formatting doesn't seem to work in the sphinx builds though.

@mtbc
Copy link
Member Author

mtbc commented Jul 3, 2013

I wonder if a ticket could note the need for a further PR to make the suggested changes to text not actually introduced by this rebase PR.

@pwalczysko
Copy link
Member

Created the ticket. https://trac.openmicroscopy.org.uk/ome/ticket/11223. I the americanization seems to work.
Ready to merge.

@mtbc
Copy link
Member Author

mtbc commented Jul 3, 2013

Great, thanks -- many good suggestions for another round.

chris-allan added a commit that referenced this pull request Jul 4, 2013
Americanize spellings, fix typos, expand contractions (rebased)
@chris-allan chris-allan merged commit ff33028 into ome:develop Jul 4, 2013
@mtbc mtbc deleted the americanize-spellings-dev branch July 4, 2013 10:28
@jburel
Copy link
Member

jburel commented Sep 9, 2013

--rebased-from #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants