New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Model & OME-TIFF Docs rework #434
Conversation
OMEXMLService service = factory.getInstance(OMEXMLService.class); | ||
|
||
|
||
.. seealso:: :bf_doc:`developers/export2.html` and :bf_doc:`developers/conversion.html` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 hyperlinks could use a more explicit test
Bah, when they didn't build correctly locally I thought it was something to do with the conf.py being at the top level & forgot to check they looked okay on the staging version - fixed now anyway. |
-------------------- | ||
|
||
In some cases, it is useful to extract specific parameters or tweak | ||
certain values in a dataset's OME-XML metadata block. Further guidance on :doc:`using-ome-xml` is available, but below is a brief example of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need for a line break here
Overall, the documentation looks much clearer in my opinion. Below are a couple of minor comments. The ome-tiff/tools page certainly lacks a bit of consistency:
There is a also commented block about the online validator in the same page. Is this a pending item that will become live in the documentation? |
The commented block is because the online validator isn't working at the moment and the link redirects to the FAQ text I have reproduced here for the BF CL instructions - Andrew has a ticket to fix it so it can be live again once that is sorted. |
Have added the supporter logos in one block to minimise new images - if it looks really pants, I can add them all individually. |
"The OME-XML metadata block may contain anything a standard OME-XML file can, including multiple OME images with multiple sets of pixels." We did away with a single image having "multiple sets of pixels" as a concept a few years ago. |
omez is out of date. Loose the line "Lastly, we saw no advantage to zipping or 7-zipping OME-XML. If you want to distribute an OME-XML file, we recommend gzipped OME-XML (omez) format, as it is the OME standard." from ome-tiff/data.html And remove the "(omez)" from the "OME-XML, gzipped (omez)" table row. Also remove from "Also good are gzipped OME-XML (omez) and zipped OME-TIFF." |
@hflynn Apart from the above comments, that are not directly related to your changes, I think this reads well and is clearer. |
Realised I'd deleted an entire sentence rather than just the 'omez' for one bit, should be ok now. |
Looks great, thanks. |
@hflynn : this is waiting on a new logos concept, no? (I'd vote for push forcing away the unused PNG) |
Logos removed, anything else? |
@ctrueden any comments before we merge & release this? @joshmoore If there are no further comments, please merge Thursday first thing. |
@hflynn: Thanks for this work. Some comments follow. Note that none of these are blockers to merging this PR. I just wanted to write my thoughts somewhere and this seemed as good a place as any.
Should that be one of:
?
Again, these are all not intended to block merging this specific PR—just general documentation suggestions spurred by the fact that @hflynn asked for my review. |
Answering 4), the |
@sbesson: Thanks for the clarification, that is neat. |
No problem, I leave the rest of your comments to @hflynn :) |
Thanks very much @ctrueden - those are really helpful and aside from the table thing, which I will have a play with another time, easily fixed here. |
@ctrueden Just to explain BTW - this is on the develop branch and is the documentation for the June 2013 data model schema so it links to all OME 5 pages because the latest version is not supported by 4.4. |
@hflynn Looks good to merge. |
Data Model & OME-TIFF Docs rework
--no-rebase |
This PR addresses tickets 10695, 11278 and 11279 which are all linked under https://trac.openmicroscopy.org.uk/ome/ticket/10274
It aims to