Skip to content
This repository has been archived by the owner on Dec 5, 2017. It is now read-only.

Support screens, plates, wells #16

Merged
merged 9 commits into from
Jan 30, 2014
Merged

Conversation

manics
Copy link
Member

@manics manics commented Dec 19, 2013

Support feature calculation and searching for Screens, Plates, Wells. Note I couldn't find a way to test PlateAcquisitions.

Also allows filtering results by screens/plates, and also adds two shortcut buttons to deselect all projects/datasets or all screen/plates.

@pwalczysko
Copy link
Member

The "Deselect All" button works okay for both Projects and Screens, but I would expect a "Select All" button as well (quite a logical complement).

@pwalczysko
Copy link
Member

Although this is not to do with this PR, I really wish now I could break up the Feature Calculation and start a new Calculation on a smaller plate (now it takes half an hour already)

@manics
Copy link
Member Author

manics commented Jan 10, 2014

I debated that, but all projects/screens are already selected by default, and the button is just a convenience method.

@pwalczysko
Copy link
Member

The reason I wanted it there was that I used the Deselect All and then I though, uh, maybe this was not the best idea - I should have not done it - immediately was looking for Select All to reverse the damage. Unfortunately, this is quite typical user behaviour. But admittedly, not a big problem.

@pwalczysko
Copy link
Member

The inability to start feature calculation on a Run is unpleasant, because Web does not show the thumbs of wells when Plate is selected, just when Run is selected. Thus, when starting to calculate the features, I cannot see the wells - not ideal.

@pwalczysko
Copy link
Member

In summary, it works on screens and plates, I can search across both P/Ds and Screens/Wells and can refine the results nicely.
The remarks above are concerned with user-friendliness rather than with bugs or functionality.
The most annoying is the complicated workflow coming from the fact that I have to go to Runs to see the thumbs, then calculate features on Screens or Plates, but then I have to go back to Runs in order to see the thumbs (wells) in order to select the image I want to run a search for. This is not a workflow which a user will ever grasp without help/explanation.

But for this PR, I think it does what it says and fine to merge.

@manics
Copy link
Member Author

manics commented Jan 10, 2014

It's easy enough to add a select all button, I was just worried about cluttering the UI.

@pwalczysko
Copy link
Member

If you talk about the Select All button, there is a possibility to show the Select All button only and after Deselect All was pressed (maybe not optimal, but it does not clutter anything).

@manics
Copy link
Member Author

manics commented Jan 10, 2014

That's not quite so straightforward, since if the user individually checks (or unchecks) all checkboxes the button would also need to change between select/deselect, in a similar way to how the checkboxes behave for datasets and projects. E.g. if you tick all datasets in a project the project gets ticked, if you untick all datasets in a project the project gets unticked. Unfortunately extending this to a third level (checkbox for all/no projects) is quite complicated, which si why I included the button as an imperfect workaround.

@pwalczysko
Copy link
Member

Okay, that makes sense. I would leave as it is then.

@pwalczysko
Copy link
Member

Works just as before.
I just noticed some thumb problem in the list:
screen shot 2014-01-20 at 15 13 26

@manics
Copy link
Member Author

manics commented Jan 20, 2014

That's an ongoing problem.

@icaoberg
Copy link
Contributor

is omero generating the thumbnails on the fly or caching them? is this a problem only with web or it happens with the clients as well?

@pwalczysko
Copy link
Member

This is probably rather a question at @will-moore

@pwalczysko
Copy link
Member

In my experience not a very common problem even in OMERO.web.

@will-moore
Copy link
Member

What size are the thumbnails? Best to use size 96 (then you'll be getting ones that are already created and cached on the server). But using different size "shouldn't" cause a problem. What do you see if you open the src of a broken thumbnail in it's own window?

manics added a commit that referenced this pull request Jan 30, 2014
Support screens, plates, wells
@manics manics merged commit 41f2ca2 into ome:master Jan 30, 2014
@manics manics deleted the spw-11069 branch February 27, 2014 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants