Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web proxy configuration support for linux clients network probes #1070

Merged
merged 2 commits into from Apr 26, 2013

Conversation

zeb
Copy link
Member

@zeb zeb commented Apr 19, 2013

Notes:

  • Linux Java clients affected: insight, editor, importer
  • Windows/MacOS clients not affected (network availability detected via network interface)
  • UpgradeCheck behaviour affected on all clients behind a proxy: failing to configure proxy settings will result in timeout on connection to http://upgrade.openmicroscopy.org.uk (and possibly skewed usage stats). Not adressed here.
  • Client server compatibilty check kicks in before NetworkChecker - not sure whether this is the intended behaviour (should it be the other way around?)

Detect network availability in NetworkChecker using HTTP URL
instead of plain socket connection : this allows clients connecting
to the internet through a web proxy to configure HTTP proxy settings
for the JVM in startup shell scripts.

Adresses problem reported in OMERO user discussion forum at
http://www.openmicroscopy.org/community/viewtopic.php?f=4&t=4509
@jburel
Copy link
Member

jburel commented Apr 19, 2013

@zeb: we are currently modifying the logging system to use logback instead of log4 see #1062, so I will avoid introducing now the logger in NetworkCheck class since that is the strategy in place in insight (library like slf4j did not exist at the time)
That could be reviewed when we have made the transition.

@jburel
Copy link
Member

jburel commented Apr 19, 2013

@zeb: since you edited the file, better to replace you're connecting by you are connecting to be in synch with the rest of our doc

@zeb
Copy link
Member Author

zeb commented Apr 22, 2013

@jburel done - see 7929509

@bpindelski
Copy link

Tried testing locally, but didn't really manage to get a timeout. The changes in code look ok and the Insight process is started with proxy settings (if the .sh file is modified). Looks ok to merge.

@joshmoore
Copy link
Member

Created a follow ticket: https://trac.openmicroscopy.org.uk/ome/ticket/10815

Thanks, @zeb!

joshmoore added a commit that referenced this pull request Apr 26, 2013
Add web proxy configuration support for linux clients network probes
@joshmoore joshmoore merged commit 230368e into ome:develop Apr 26, 2013
@zeb
Copy link
Member Author

zeb commented Apr 29, 2013

@joshmoore Thanks. Just wondering if this might be included into the dev_4_4 line?
@jburel If the anwser to the above is yes, wondering how to deal with f458c53 which made it into dev_4_4 but not into develop

@jburel
Copy link
Member

jburel commented Apr 29, 2013

@zeb, @joshmoore: The reason it did not make it to develop is that we will require Java 1.6 or higher. so the Java 1.5 specific code should be removed.

@jburel jburel mentioned this pull request Jun 27, 2013
@sbesson sbesson modified the milestones: 5.0.0-alpha2, 5.0.0 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants