Case-insensitive matching of errors/warnings in admin diagnostics

[zeb]

To test the change (assuming a stopped server):

• invalidate Ice grid configuration : echo "RaiseAnIceXMLParserExceptionAtStartup" >> $OMERO_HOME/etc/grid/templates.xml
• run omero admin start : server starts up despite invalid XML syntax
• run omero admin diagnostics : log files report for master.err should now display positive errors and warnings counts

[bpindelski]

This definitely enables the display of errors/warnings count from master.err. I wonder if a more general solution would be better: lower the case of each line returned by p.lines() as now we handle each case type separately (what if in the future a component will print Error or eRror?).

[zeb]

@bpindelski Thanks, updated implementation according to suggested solution.

[joshmoore]

Travis error is just a timeout as frequently happens. @bpindelski : any comments?

[bpindelski]

@joshmoore, @zeb Looks better now. Good to merge.

[zeb]

@bpindelski, @joshmoore Ok. I guess a backport onto dev_4_4 will be required?

[joshmoore]

Certainly can't hurt, @zeb. That's certainly what you're more likely to be deploying in the short-term.