Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matlab fixes #1160

Merged
merged 4 commits into from May 16, 2013
Merged

Matlab fixes #1160

merged 4 commits into from May 16, 2013

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented May 10, 2013

This PR addresses http://trac.openmicroscopy.org.uk/ome/ticket/10805 by

  • allowing the following signatures to be used

    getImages(session, 'project' ,[]);
    getImages(session, 'dataset' ,[]);
    
  • allowing to pass objects when retrieving annotations

    getDatasetCommentAnnotations(session, datasets)
    getImageXmlAnnotations(session, images)
    

    and modifying all the annotations retrieving function headers accordingly

@manics
Copy link
Member

manics commented May 13, 2013

Works as expected. The getObjectAnnotations comment header could do with a few changes, such as change files to anns, change example to be a proper example, though this can wait till the next round of changes.

@joshmoore
Copy link
Member

@sbesson: 👍 or do you want to do any more changes here?

@sbesson
Copy link
Member Author

sbesson commented May 15, 2013

Added commit 99aa64e which should address Simon issue and document new signature in getObjectAnnotations

@joshmoore
Copy link
Member

@manics?

@manics
Copy link
Member

manics commented May 16, 2013

good to merge

joshmoore added a commit that referenced this pull request May 16, 2013
@joshmoore joshmoore merged commit c4dac20 into ome:dev_4_4 May 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants