Don't show green tick if delete Error. See #10900

[will-moore]

To test, try to delete Dataset containing partial MIF. This should fail (for an unknown reason) as described https://trac.openmicroscopy.org/ome/ticket/10900 BUT you should see a red triangle in the activities dialog instead of a green tick.

[chris-allan]

Performing a delete as outlined does indeed result in a red triangle rather than a green tick. However, when using the following as a delete target:

• gretzky
• private-1; user-2
• dataset "chris-pr-1193"

The following exception is present in the OMERO.web server log:

2013-05-21 16:24:44,837 WARNI [                           omero.gateway] (proc.15287) debug:3439 ValueError on <class 'omeroweb.webclient.webclient_gateway.OmeroWebSafeCallWrapper'> to <06efba47-ff32-49c9-8e89-c220e14eab97omero.api.IContainer> getImages(('Dataset', [u'34'], None, <ServiceOptsDict: {'omero.session.uuid': '58722156-f97c-4c17-bf22-b19b954ed78f', 'omero.group': '-1', 'omero.client.uuid': '06efba47-ff32-49c9-8e89-c220e14eab97'}>), {})
Traceback (most recent call last):
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero/gateway/__init__.py", line 3457, in __call__
    return self.f(*args, **kwargs)
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero_api_IContainer_ice.py", line 106, in getImages
    return _M_omero.api.IContainer._op_getImages.invoke(self, ((rootType, rootIds, options), _ctx))
ValueError: invalid value for element 0 of sequence<long>
2013-05-21 16:24:44,854 ERROR [                omeroweb.webclient.views] (proc.15287) activities:2214 Traceback (most recent call last):
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omeroweb/webclient/views.py", line 2184, in activities
    attempted_imgIds = [i.id.val for i in cs.getImages(dtype, obj_ids, None, conn.SERVICE_OPTS)]
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero/gateway/__init__.py", line 3460, in __call__
    return self.handle_exception(e, *args, **kwargs)
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omeroweb/webclient/webclient_gateway.py", line 1941, in handle_exception
    e, *args, **kwargs)
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero/gateway/__init__.py", line 3457, in __call__
    return self.f(*args, **kwargs)
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero_api_IContainer_ice.py", line 106, in getImages
    return _M_omero.api.IContainer._op_getImages.invoke(self, ((rootType, rootIds, options), _ctx))
ValueError: invalid value for element 0 of sequence<long>

2013-05-21 16:24:44,854 ERROR [                omeroweb.webclient.views] (proc.15287) activities:2215 Status job '58722156-f97c-4c17-bf22-b19b954ed78f/IHandlea4df925f-f4ec-41d6-b0fd-eb5a32ccddc7 -t:tcp -h 134.36.65.227 -p 42914'error:

Perhaps this is covered by the already open gh-1190 but I thought I should mention it here as well as it does appear to be an OMERO.web logic error rather than a delete error per say.

[will-moore]

@chris-allan I left the fixing of the actual error for an extra day to give us the chance to test the red triangle! The fix will-moore@9820373 is in #1190 for tomorrow.

I kept the green tick issue to a separate PR (this one) so it can be more easily ported to dev_4_4

[will-moore]

@chris-allan @joshmoore So I think this is good to merge.

[chris-allan]

The user interface acts as expected and with the changes in gh-1190 I can confirm that this works as expected. Ready to merge.