Activities mif removal 11002 #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 23, 2013 09:52
|
The error handling in activities is okay. See my comments at #1221 . Unfortunately, the errors came without any tricking using Insight or other web client. Seems to work fine. |
|
@will-moore : 1203 is in if you wanted to rebase. Is there any particular other testing you want attempted? |
|
@joshmoore Does rebase give us any wins (apart from cleaner PR)? |
|
Cleaner PR but also a cleaner git tree (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds only a single commit to #1203 to remove all MIF-specific handling from the Activities panel, since this is now handled BEFORE we submit to chgrp or delete.
Tricky to test if you've also got #1221 merged in, since you won't be able to go ahead with chgrp or delete of a MIF. However, you can test delete or chgrp error handling by choosing to delete or chgrp (E.g. empty Dataset), but before you hit "OK", use Insight (or webclient in a different browser/window to delete the Dataset).
Should see standard error handling in Activities (which will be the same for MIFs now).