script_ui ignores defaults if omero.model objects. See #11243 #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2382,6 +2382,8 @@ def script_ui(request, scriptId, conn=None, **kwargs): | |||
| i["options"] = [v.getValue() for v in param.values.getValue()] | |||
| if param.useDefault: | |||
| i["default"] = unwrap(param.prototype) | |||
| if isinstance(i["default"], omero.model.IObject): | |||
| i["default"] = None | |||
| pt = unwrap(param.prototype) | |||
There was a problem hiding this comment.
seems weird to unwrap it twice within a couple of lines, but maybe it's a trivial fast operation
|
This PR's description's test step results work as expected. (-: |
chris-allan
added a commit
that referenced
this pull request
Jul 11, 2013
script_ui ignores defaults if omero.model objects. See #11243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use script parameter default E.g:
default=omero.model.OriginalFileI()to populate the field in the script UI.To test:
--rebased-to #1343