-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build insight #1453
Build insight #1453
Conversation
The windows clients are not generated and not published.
This works well for me and thus seems good to merge. @pwalczysko, did you want to try removing your exe4j installation with |
I did exactly as advised by @mtbc above and then I have merged this PR into my local branch and ran |
I have the same problem on develop as well. |
@bpindelski: happy with the changes? |
@jburel LGTM. Works as expected. |
@jburel On second thought, there is no insight-win.zip being created even with exe4j present on my Mac... |
There is also no insight-win.zip on hudson - see http://hudson.openmicroscopy.org.uk/job/OMERO-merge-stable/lastBuild/artifact/src/target/pkg/ - the size of the ...win.zip is zero. |
@pwalczysko, @bpindelski: that's a way to reduce the windows bugs ;-) |
@pwalczysko, @bpindelski: The last commit should fix the reported issue. |
@jburel Looks better now. All the |
--rebased-to #1472 |
To test the PR run the following command without exe4j installed.
see https://trac.openmicroscopy.org.uk/ome/ticket/11408