Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build insight #1453

Merged
merged 2 commits into from
Sep 11, 2013
Merged

Build insight #1453

merged 2 commits into from
Sep 11, 2013

Conversation

jburel
Copy link
Member

@jburel jburel commented Sep 5, 2013

To test the PR run the following command without exe4j installed.

./build.py release-clients

see https://trac.openmicroscopy.org.uk/ome/ticket/11408

The windows clients are not generated and not published.
@mtbc
Copy link
Member

mtbc commented Sep 6, 2013

This works well for me and thus seems good to merge.

@pwalczysko, did you want to try removing your exe4j installation with sudo mv /opt/exe4j /tmp and seeing if this solves your issue?

@pwalczysko
Copy link
Member

I did exactly as advised by @mtbc above and then I have merged this PR into my local branch and ran ./build.py clean && ./build.py. After this I ran ./build.py release-clients and it worked fine - clients were built and I could unzip and run Insight from the target folder.
So for me this solves the issue. I guess the other concerned people want to be sure they can still build the clients as well with this PR ?

@pwalczysko
Copy link
Member

I have the same problem on develop as well.

@jburel
Copy link
Member Author

jburel commented Sep 10, 2013

@bpindelski: happy with the changes?

@bpindelski
Copy link

@jburel LGTM. Works as expected.

@bpindelski
Copy link

@jburel On second thought, there is no insight-win.zip being created even with exe4j present on my Mac...

@pwalczysko
Copy link
Member

There is also no insight-win.zip on hudson - see http://hudson.openmicroscopy.org.uk/job/OMERO-merge-stable/lastBuild/artifact/src/target/pkg/ - the size of the ...win.zip is zero.

@jburel
Copy link
Member Author

jburel commented Sep 10, 2013

@pwalczysko, @bpindelski: that's a way to reduce the windows bugs ;-)

@jburel
Copy link
Member Author

jburel commented Sep 10, 2013

@pwalczysko, @bpindelski: The last commit should fix the reported issue.

@bpindelski
Copy link

@jburel Looks better now. All the *-win-*.zip artefacts are back. Should be good to merge.

@joshmoore joshmoore mentioned this pull request Sep 11, 2013
joshmoore added a commit that referenced this pull request Sep 11, 2013
@joshmoore joshmoore merged commit 6234752 into ome:dev_4_4 Sep 11, 2013
@jburel jburel mentioned this pull request Sep 11, 2013
@jburel
Copy link
Member Author

jburel commented Sep 11, 2013

--rebased-to #1472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants