New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image viewer split 11285 #1462
Image viewer split 11285 #1462
Conversation
cc @cneves @chris-allan Significant change to web image viewer (and Blitz Gateway). |
The functionality all looks fine and good to merge in that respect. In testing I did notice this issue with channel labels, #11445 |
@ximenesuk Could you confirm whether the channel labels issue is fixed now? |
@@ -7002,7 +7002,7 @@ def splitChannelDims (self, border=2): | |||
return rv | |||
|
|||
def _renderSplit_channelLabel (self, channel): | |||
return str(channel.getEmissionWave()) | |||
return str(channel.getLabel()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change also to align with OMERO.insight's display?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-allan Yes - Insight uses Channel Names for split view panels:
Reviewed, thumbs up on merging this in. |
Cool. Also thumbs up merging this in. |
--rebased-to #1509 |
This allows more than 1 channel to be active when showing split-view layout in the web image viewer (similar behaviour as Insight).
To test: