Use reverse('webgateway') for viewport_server. See #11451 #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@will-moore: by currently, do you mean w/o the PR? |
|
Yes - currently at the time I wrote it (before PR was open). |
|
@will-moore header should be updated. i.e. 2013 |
will-moore
pushed a commit
to will-moore/openmicroscopy
that referenced
this pull request
Sep 17, 2013
|
@jburel That's the copyright date fixed. Did you test the image-viewer? Are we good to merge? |
|
I did test. Yes. working. |
|
--rebased-to #1491 |
jburel
added a commit
that referenced
this pull request
Sep 17, 2013
…velop
Use reverse('webgateway') for viewport_server. See #11451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes resolution of various urls in the webgateway image viewer when deployed on a server with a url prefix (as on gretzky: /omero/webgateway/
To test, log in to gretzky as user-1 and go to:
https://gretzky.openmicroscopy.org.uk/omero/webgateway/img_detail/2958/
Viewer should load and display as normal - Currently no json or image data is loaded (404).