Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6850 loading tile in big image viewer #1529

Merged
merged 3 commits into from Sep 25, 2013
Merged

6850 loading tile in big image viewer #1529

merged 3 commits into from Sep 25, 2013

Conversation

atarkowska
Copy link
Member

Test this PR on slower connections between web & server (perhaps development server is the best to test) with FF, IE, Chrome

  1. Load a big image, grab red box in bird's eye, click and drag it around. Now, it should delay moving viewer until you stop moving mouse (you don't need to release mouse button). After 300ms viewer should move to the right location. See https://trac.openmicroscopy.org.uk/ome/ticket/6850
  2. Previously every time user clicked zoom button or spin the mouse wheel all tiles were loaded. After many seconds if not a few minutes, final zoom level was eventually displayed. Now zooming event should be delayed by 300ms and only final level should request tiles.

All requests should be easily accessible on the webserver access log.

Currently delay time is set to 300 ms, but it could be changed if users see that too short.

@atarkowska
adding delay before positioning tiles in the viewer, see #6850
31355d7 
this will prevent from loading tiles when user triggered another action
for example: if user zooms using mouse-wheel it will load only
tiles from the final level rather then all levels
@atarkowska
adding delay value to the vieport
0a9af3e
@atarkowska
fixing delay param in bird eye, close #6850
9862999
@will-moore
Copy link
Member

@aleksandra-tarkowska All looks fine and seems to be working well for me. Delay seems to be about the right value too.
Good to merge.

@atarkowska
Copy link
Member Author

@cneves , @chris-allan do you have any comment about it?

@cneves
Copy link
Member

cneves commented Sep 23, 2013

@aleksandra-tarkowska I did not test it but the code looks good and the change welcome, so thumbs up.

joshmoore added a commit that referenced this pull request Sep 25, 2013
@joshmoore
Merge pull request #1529 from aleksandra-tarkowska/6850_loading_tile
274f831 
6850 loading tile in big image viewer
@joshmoore joshmoore merged commit 274f831 into ome:develop Sep 25, 2013
@atarkowska atarkowska mentioned this pull request Sep 25, 2013
Merged
@mtbc
Copy link
Member

mtbc commented Sep 26, 2013

--rebased-to #1545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
develop
Projects
None yet
Milestone
5.0.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atarkowska @will-moore @cneves @mtbc @joshmoore