Default group

[jburel]

Allows the user to change the default group see https://trac.openmicroscopy.org.uk/ome/ticket/11481

[gusferguson]

@jburel @mporter-gre

Can only test client side - Michael will have to test the Matlab side.

No testing instructions but tested as follows with OMERO.insight-4.4.8-959-8b68c53-ice33-b381-mac on howe user-3 read-only-1 and read-annotate-1.

Behaves as expected when changing default group in right hand pane.
Change in default group persists in next session.
Behaves as expected when non-default group is only one visible, close app and re-start - visible group on close becomes default on re-open.

Note for future testing: this switch of default groups does not happen if you just use "switch user" to log out and log back in - have to quit app.

[jburel]

@gusferguson: no matlab side as such.
The last comment i.e. switch user is a corner case but should probably be addressed.

[jburel]

@gusferguson: the last commits will set the default group when switching user (only if one group displayed)

[gusferguson]

@jburel

Tested using OMERO.insight-4.4.8-974-36bf6ed-ice33-b382-mac user-3 read-only-1 and read-annotate-1

Changing default group using drop down in right hand pane:

Quite a bit of inconsistency as are getting conflict between right hand pane change and only visible group change over-riding default group selection.
Also getting inconsistency between switch user and quit - Case 2 and Case 5:

Case 1

• read-annotate-1 default
• read-only-1 not showing in data tree
• change default to read-only-1 in right hand pane
• switch users
• read-annotate-1 remains as default

Case 2:

• read-annotate-1 default
• read-only-1 is showing in data tree
• select user-3 in either read-annotate-1 or read-only-1 group
• change default to read-only-1 in right hand pane
• switch users
• read-only-1 becomes default

Case 3

• read-annotate-1 default
• read-only-1 not shown in data tree
• change default to read-only-1 in right hand pane
• quit app
• read-annotate-1 remains as default

Case 4

• read-annotate-1 default
• read-only-1 is shown in data tree
• select user-3 in read-only-1 group
• change default to read-only-1 in right hand pane
• quit app
• read-only-1 becomes default

Case 5:

• read-annotate-1 default
• read-only-1 is shown in data tree
• select user-3 in read-annotate-1 group
• change default to read-only-1 in right hand pane
• quit app
• read-annotate-1 remains as default

If:

• read-annotate-1 default
• read-only-1 is shown in data tree
• select user-3 in read-only-1 group
• change default to read-only-1 in right hand pane
• select read-annotae-1 in data tree
• right hand pane default group selection changes back to read-annotate-1
• note - the "Save" button never becomes active when you change the dealt group
• maybe that is the problem - change of default group not being saved unless you quit before data tree selection is changed?

Summary:

• single group shown in data tree becomes default on both switch user and quit
• this over-rides any right pane selection of non-visible group
• right-hand pane selection and switch user consistently work when any group selected in data tree
• right-hand pane selection only works when new default group is selected in data tree at time of selection and without changing data tree selection before quitting.

I think that covers all possible combinations.

[jburel]

The tree will override changes made on the right-hand side. I am not sure how we want to handle that. If we modify in right-hand side during the session never consider the tree?

The saving action happens w/o need to click on the save button. Do we want to change that?

[gusferguson]

@jburel

That would get quite complicated. It goes beyond just that though - the change in default group is not sticking after a change of selection even without quitting/switching user - just changing group in the data tree. i.e. there is no "save" taking place

[jburel]

After discussion with @gusferguson, only allow to change the default group from the right-hand side.
The save from the tree is more for preferences.

[jburel]

@gusferguson: the last commits should

• not change the default group from the tree.
• change the group from the right-hand panel after clicking on the SAVE button

[gusferguson]

@jburel

Tested with OMERO.insight-4.4.8-994-3f0d736-ice33-b383-mac user-3 read-annotate-1 and read-only-1

Behaves as expected

• only selection by drop-down box and "Save" is changing group

This feels much better and more intuitive than the previous workflow. I will add this to the training docs for 4.4.9

[jburel]

@gusferguson: okay if we merge?

[gusferguson]

@jburel Good to merge

[jburel]

--rebased-to #1560