Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation test #1564

Merged
merged 9 commits into from Oct 7, 2013
Merged

Annotation test #1564

merged 9 commits into from Oct 7, 2013

Conversation

jburel
Copy link
Member

@jburel jburel commented Oct 1, 2013

Fix the tests dealing with annotations see https://trac.openmicroscopy.org.uk/ome/ticket/11366

I have also added more tests to handle various group permissions permutations

2 new tests will fail (rwrw-- to rw----). They are marked as broken.

To test the PR, run the following command

./build.py -f components/tools/OmeroJava/build.xml test -DTEST=integration/chgrp/AnnotationMoveTest

annotationIdsUser2.size());
/**
* Test to move an image with annotation. Context: - 2 users annotate the
* image with non sharable annotations. - Owner move the image to a RWRA--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to RWRW-- ?

@mtbc
Copy link
Member

mtbc commented Oct 2, 2013

Great refactoring, and tests not marked as broken all pass.

@jburel
Copy link
Member Author

jburel commented Oct 2, 2013

@mtbc: updated the javadoc.

@mtbc
Copy link
Member

mtbc commented Oct 2, 2013

Thank you, good to merge.

@bpindelski
Copy link

@jburel Thanks. Number of passing tests in OmeroJava-integration-stable has increased.

joshmoore added a commit that referenced this pull request Oct 7, 2013
@joshmoore joshmoore merged commit 9ebb2fb into ome:dev_4_4 Oct 7, 2013
@jburel
Copy link
Member Author

jburel commented Oct 11, 2013

--rebased-to #1615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants