Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ie8 fixes 9771 #1737

Merged
merged 3 commits into from
Nov 12, 2013
Merged

Ie8 fixes 9771 #1737

merged 3 commits into from
Nov 12, 2013

Conversation

will-moore
Copy link
Member

This fixes a couple of issues in IE8:
See: https://trac.openmicroscopy.org.uk/ome/ticket/9771

To test (on IE8):
Right-click menu on the P/D/I tree - check that disabled items appear disabled and that sub-menus of disabled items look OK too.
Check that P/D creation works OK, new P/D inserted into the tree etc.

@atarkowska
Copy link
Member

those works ok, but refresh button failed on

SCRIPT5007: Unable to get value of the property 'split': object is null or undefined 
webclient, line 1700 character 9

basically there is not spinning wheel while refresh. This seems to be IE issue, also in IE9

The same issue on FF

TypeError: get_selected.attr(...) is undefined
if (get_selected.attr('id').split("-")[0] === 'plate') {

@will-moore
Copy link
Member Author

@aleksandra-tarkowska Thanks - should be fixed now.

@atarkowska
Copy link
Member

Works fine, there is another issue with spinner, but I will open separate PR for that. Ready to merge

joshmoore added a commit that referenced this pull request Nov 12, 2013
@joshmoore joshmoore merged commit 90ff69a into ome:dev_4_4 Nov 12, 2013
@will-moore will-moore deleted the ie8_fixes_8713 branch November 13, 2013 10:34
@will-moore
Copy link
Member Author

--rebased-to #1760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants