Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating dialog #1775

Merged
merged 1 commit into from Nov 15, 2013
Merged

Floating dialog #1775

merged 1 commit into from Nov 15, 2013

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 14, 2013

Close dialog when it loses focus
see http://trac.openmicroscopy.org.uk/ome/ticket/11698

@joshmoore
Copy link
Member

Restarted travis since failure was:

Download error on http://pypi.python.org/simple/pytest/: [Errno 111] Connection refused -- Some packages may not be found!

/cc @ximenesuk

@mtbc
Copy link
Member

mtbc commented Nov 15, 2013

I was interested to see what this did under XFCE4 with focus-follows-mouse but actually it is fine, the floating dialog doesn't actually lose focus so long as the mouse pointer is still within the "parent" Insight window, and then clicking outside it dismisses the dialog.

Good to merge (travis permitting).

@jburel
Copy link
Member Author

jburel commented Nov 15, 2013

--no-rebase

@jburel
Copy link
Member Author

jburel commented Nov 15, 2013

@mtbc Thanks for your tests.

jburel added a commit that referenced this pull request Nov 15, 2013
@jburel jburel merged commit 85039e3 into ome:develop Nov 15, 2013
@jburel jburel deleted the floating-dialog branch November 15, 2013 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants