Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webstart popup windows 11656 #1781

Merged
merged 3 commits into from
Nov 27, 2013

Conversation

will-moore
Copy link
Member

Fixes webstart security popup in main webclient window by linking to /webstart/ homepage instead: see https://trac.openmicroscopy.org.uk/ome/ticket/11656

To test:

  • On Windows, Firefox open /webclient/ - see that Java plugin doesn't appear in toolbar.
  • Click webstart button in toolbar - should open a popup window with /webstart/ - Check that webstart works OK.
  • Note that /webstart/ page doesn't have webclient and webstart displayed equally - this was confusing.
  • The webclient link will close the webstart window (if it has been opened from webclient).
  • If you open a new Tab and go directly to /webstart/ the webclient link and text is slightly different - will open webclient in same window.

@mtbc
Copy link
Member

mtbc commented Nov 18, 2013

I hope that it's okay that when I start webstart Insight I am warned that it will be blocked in a future Java security update because the JAR manifest doesn't have the Permissions attribute. (Is this ticketed?)

@mtbc
Copy link
Member

mtbc commented Nov 18, 2013

Indeed gets rid of the other scary message and otherwise works as described. Good to merge.

@manics
Copy link
Member

manics commented Nov 18, 2013

@will-moore
Copy link
Member Author

Yeah - this is what I see on windows - looks pretty scary!

screen shot 2013-11-15 at 12 06 50

@joshmoore
Copy link
Member

So the "good to merge" stands despite the scariness, right?

@mtbc
Copy link
Member

mtbc commented Nov 21, 2013

Right, the scariness is for a different PR. (-:

@will-moore
Copy link
Member Author

@joshmoore I think this is good to merge

@joshmoore
Copy link
Member

Cool, thanks. /cc @gusferguson / @hflynn -- don't know if there are any docs or tutorials that need to be updated.

joshmoore added a commit that referenced this pull request Nov 27, 2013
@joshmoore joshmoore merged commit 28caf88 into ome:dev_4_4 Nov 27, 2013
@joshmoore
Copy link
Member

--rebased-to #1840

@will-moore will-moore deleted the webstart_popup_windows_11656 branch January 23, 2014 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants