Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev_4_4: Add Annotation and OriginalFile IDs to OMERO.web FileAnnotation tooltip #1786

Merged
merged 2 commits into from
Nov 20, 2013

Conversation

chris-allan
Copy link
Member

It is useful to see the Annotation and OriginalFile IDs in the FileAnnotation tooltip. This is especially true when the FileAnnotation links to an OMERO.tables instance where the OriginalFile ID is used to retrieve a reference to the the table via the API.

Before:

screen shot 2013-11-18 at 10 18 14

After:

screen shot 2013-11-18 at 10 18 31

The added Namespace in the screenshot is from 4.4.9 and was added in f669a15. The before screenshot is from 4.4.8p1. Please ignore.

To Test

  1. Pick any container or Image
  2. Attach a file
  3. Mouse over the annotation in the right hand panel
  4. Confirm that the IDs are displayed

@sbesson
Copy link
Member

sbesson commented Nov 19, 2013

Tested using howe. Works as expected and ready to merge.

screen shot 2013-11-19 at 11 15 25

As a follow-up of this change, I would be inclined to suggest 2 trivial tickets/PRs:

  • implement the same behaviour in Insight to keep compatibility between clients
  • potentially expose the Annotation ID in the clients for any kind annotation.

/cc @gusferguson @jburel @pwalczysko

@joshmoore
Copy link
Member

@sbesson : can you file those tickets SVP? Merging this PR along with its partner for next testing cycle.

joshmoore added a commit that referenced this pull request Nov 20, 2013
dev_4_4: Add Annotation and OriginalFile IDs to OMERO.web FileAnnotation tooltip
@joshmoore joshmoore merged commit b3b071d into ome:dev_4_4 Nov 20, 2013
@sbesson
Copy link
Member

sbesson commented Nov 20, 2013

Ticket created https://trac.openmicroscopy.org.uk/ome/ticket/11731 and PR opened against develop gh-1808

@mtbc
Copy link
Member

mtbc commented Nov 21, 2013

--rebased-to #1787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants