Disable chgrp event logs #1843
Merged
Disable chgrp event logs #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--rebased-to #1845 |
| @@ -176,14 +176,12 @@ public void setEventContext(EventContext ec) { | |||
| this.ec = ec; | |||
| } | |||
|
|
|||
| /** | |||
| * To reduce overhead, we're no longer copying this array. | |||
| * @return | |||
|
Those fakes each make 2.5GB of Pixels and chgrp successfully in under 45s on my notebook. Good to merge. |
|
Thanks, Javadoc improvement is good, still good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creation of
CHGRPevent logs for the planeinfo elements of screens (or even justa&exposureTime=1.0&sizeT=10000.fakewith ome/bioformats#795) was taking significant time. In fact theonReleasemethod was taking nearly half of the time just to publish events. Since CHGRP events do not take part in indexing (as do the DELETE event logs), this optimization should be generally safe.To test:
bin/omero chgrp A /Image:...on the newly created image.Without this PR, that move will take many minutes, if it does not OOM the server. With it, it should take less than a minute (e.g. on my fairly fast linux box, ~20 seconds, as opposed to the 5+ minutes I waited before Ctrl-C'ing it without the PR )
/cc @jburel, @pwalczysko, @chris-allan