Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate postgres startup #11793 #1873

Merged
merged 5 commits into from Dec 9, 2013

Conversation

manics
Copy link
Member

@manics manics commented Dec 5, 2013

OMERO-homebrew-develop and OMERO-homebrew-STABLE regularly failed because Postgres was being started twice.

Note this requires changes to the jenkins job- since the postgres data dir is explicitly set it is necessary to run /usr/local/bin/pg_ctl -D$PSQL_DIR -m fast stop instead of /usr/local/bin/brew services stop postgres. Try runnning this job a few times to check it works.

@manics
Copy link
Member Author

manics commented Dec 6, 2013

--rebased-to #1882

@sbesson
Copy link
Member

sbesson commented Dec 7, 2013

http://hudson.openmicroscopy.org.uk/job/OMERO-homebrew-develop/ completed successfully in the last 2 builds. Are you planning any other commit @manics?

@manics
Copy link
Member Author

manics commented Dec 7, 2013

That's all, unless you can think of a nicer alternative to killall postgres

@sbesson
Copy link
Member

sbesson commented Dec 7, 2013

An alternative would be to remove it from the OMERO-homebrew-install.sh script and add it to the Jenkins shell script right before OMERO-homebrew-install.sh is invoked.

@sbesson
Copy link
Member

sbesson commented Dec 9, 2013

joshmoore added a commit that referenced this pull request Dec 9, 2013
Remove duplicate postgres startup #11793
@joshmoore joshmoore merged commit eabb0e6 into ome:develop Dec 9, 2013
@manics manics deleted the omero_homebrew_postgres_start branch December 11, 2013 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants