Reset Image.archived flag where necessary (Fix #11810) #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the upgrade testing of nightshade for 5.0.0-beta2-rc3, images were found which had incorrect `archived`. This won't prevent the flags from being mis-set again, but for starting with `5.0__0` it will at least be consistent.
|
Note: on the NS clone this would |
|
Changes look OK. Do we want to test this piece of SQL on some real data before merging? |
|
@bpindelski : agreed that this is what this needs, but as with @mtbc's recent PR this is difficult, because we can't do the upgrade testing as frequently. I'll merge now, and work out a plan with @pwalczysko to have one more nightshade upgrade testing phase. |
joshmoore
added a commit
that referenced
this pull request
Dec 17, 2013
Reset Image.archived flag where necessary (Fix #11810)
|
--no-rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the upgrade testing of nightshade for 5.0.0-beta2-rc3,
images were found which had incorrect
archived. This won'tprevent the flags from being mis-set again, but for starting
with
5.0__0it will at least be consistent.