fix #10822: add "local" options to omero.fs.repo.path_rules

[mtbc]

Make sure that the Blitz unit tests FilePathRestrictionsTest and MakePathComponentSafeTest still pass.

Try using local required and local optional in etc/omero.properties for omero.fs.repo.path_rules (remember ./build.py update-version before restarting the server; you know if your changes are being taken because if you put a nonsense setting then there will be a stack trace in Blitz-0.log). These should limit sanitization of import paths according to the machine upon which the server is running.

To see the extra log message from CurrentPlatform you may have to adjust levels in logback.xml.

To understand the path sanitization rules see http://www.openmicroscopy.org/site/support/omero5-staging/sysadmins/fs-upload-configuration.html#legal-file-names

Fixes https://trac.openmicroscopy.org.uk/ome/ticket/10822.
--no-rebase as FS-specific.

[ximenesuk]

Results from FilePathRestrictionsTest on MacOS is all passes except for two skips.:

testUnsafeCharacterUnsafetyLinux    0.002s  
testUnsafeCharacterUnsafetyWindows  0.000s  

Given the OS I assume these skips are expected.

With MakePathComponentSafeTest I'm less certain since the following are skipped:

testPlatformTestExecuted    0.004s  
testUnsafeCharacterUnsafetyLinux    0.000s  
testUnsafeCharacterUnsafetyWindows  0.000s  

Should the first of these be skipped?

[mtbc]

Yes, testPlatformTestExecuted is skipped if we have identified the platform (and one of the platform-specific tests executed instead): it contains a fail for if platform identification fails.

[ximenesuk]

Thanks for the clarification. I am seeing (with appropriate log tweaking) a log line confirming the current platform. However, I have only tested this PR on Mac OS, does it require wider testing?

[mtbc]

I'll have tested it on Linux in creating it, so I expect that we're probably okay. It's probably not worth the effort of testing the Windows side, unless perhaps the CI system is already giving us a merge-build running a Windows OMERO.server somewhere, or vbox image with one in it, in which case I could try to generate further testing suggestions.

[ximenesuk]

I'm happy for this to be merged. /cc @joshmoore

[joshmoore]

👍