Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons cleanup (rebased onto dev_5_0) #1958

Merged
merged 1 commit into from
Jan 15, 2014
Merged

Icons cleanup (rebased onto dev_5_0) #1958

merged 1 commit into from
Jan 15, 2014

Conversation

atarkowska
Copy link
Member

This is the same as gh-1957 but rebased onto dev_5_0.


it turned out that there were still places where icons for shared data were indicating the difference. in order to test it check all tabs: data, tags, public whether ownership is not indicated by either 'red dot' or 'lock'

@atarkowska
Copy link
Member Author

--rebased-from #1957

@atarkowska atarkowska mentioned this pull request Jan 10, 2014
@mtbc
Copy link
Member

mtbc commented Jan 13, 2014

Maybe it is okay to get rid of the actual files left_sidebar_icon_tag_locked.png and left_sidebar_icon_tags_locked.png too.

@mtbc
Copy link
Member

mtbc commented Jan 13, 2014

It's certainly looking okay in practice on gretzky this afternoon.

@joshmoore
Copy link
Member

@aleksandra-tarkowska : are the PNGs not used elsewhere?

@atarkowska
Copy link
Member Author

@mtbc, discussed that with Will, and we agreed to not remove anything, just change the name. Ownership indicator has been turned on and off few times in the past.

@mtbc
Copy link
Member

mtbc commented Jan 15, 2014

Good to merge, then.

joshmoore added a commit that referenced this pull request Jan 15, 2014
…ons_cleanup

Icons cleanup (rebased onto dev_5_0)
@joshmoore joshmoore merged commit 8173062 into ome:dev_5_0 Jan 15, 2014
@atarkowska atarkowska deleted the rebased/dev_5_0/icons_cleanup branch January 15, 2014 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants