MT textbox

[jburel]

Do not show a dialog when the user only shows or hides comment on a shape
To avoid confusion between a text shape and a comment on a shape, I have renamed the text on a shape to
comment.
See https://trac.openmicroscopy.org.uk/ome/ticket/9742

To test:

• Open an image
• Open the measurement tool (MT). Make the text in toolbar is "Show Comment"
• Draw few shapes, add text to some of them. Save
• Select a shape, Go to inspector Tab, Make sure the name of the column is "Comment"
• Close MT and Viewer
• Open Viewer/MT
• Text should be displayed on shape.
• Un-select "Show Comment". The text on shape should no longer be displayed. Do not perform other actions.
• Close MT. Close Viewer. A Dialog indicating if you want to save ROI should NOT pop up.
• Open Viewer, open MT. Move a shape
• Close MT. Close Viewer. A Dialog indicating if you want to save ROI should pop up.

This is TAB, so PR should be rebased to 5.0.0

[pwalczysko]

Works as expected in the sense of the above workflow. Checked the ticket as well and it solves the ticket okay.

The other point (possibly for another PR) which was apparent when testing this was the fact that you cannot see what you write as you are writing the comment (the text is (nearly) invisible, because there is no background in the text box). On the other hand, once you finished writing, the whole box gets a very wide background, which obscures the middle of the shape, thus interfering with/hiding the biological feature which is inside the ROI in the first place. - this was remarked on by M Porter on some ticket already, just was reminded now how true that is.
I see that this is the idea behind the "Show comment" button in the first place, but still, I think there could be some improvements (came up also as an important feature during the OMERO.workshop - people want to mark their ROIs and see the markings & the ROIs & the image at the same time).

The other remark is - note that when the ROI was moved as instructed in the workflow, an unpleasant smudge was left "leaking" from the comment box (see screenshot), again obscuring wide area (see screenshot).

[jburel]

@pwalczysko: Thanks for the report.
I will prefer to do that in another PR. The MT needs to be totally rewritten.
Could you create a ticket?

[pwalczysko]

Created https://trac.openmicroscopy.org.uk/ome/ticket/11925.

[joshmoore]

👍

[jburel]

--rebased-to #2023