New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load default when appending to/removing from an unset omero.web property #2030
Conversation
- Update corresponding unit tests - Add test for removal of multi-defined item
Fairly long thread in chat about this which will need to get summarized, but my 2 cents are:
Otherwise, makes sense. |
@joshmoore Agreed that changes to the defaults are an issue. I don't see a simple fix for that other than an approach like #2028. |
--rebased-to #2041 |
2041 is merged. I assume this just needs a cursory once over? |
Works fine for me. This will make settings so much nicer than they are now!
But this is a very minor point. Good to merge! |
Thanks, @will-moore. Merging. re: " |
Load default when appending to/removing from an unset omero.web property
This PR extends #1905 by loading the default value from omeroweb/settings.py when a value is appended to or removed from a previously unset omero.web.* property.