New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev_5_0: Add omero config append/remove subcommands with default value handling for omero.web.* variables #2041
dev_5_0: Add omero config append/remove subcommands with default value handling for omero.web.* variables #2041
Conversation
- Update corresponding unit tests - Add test for removal of multi-defined item
👍 Extract from my modified install script:
|
One very nit-picky comment: If there are duplicate values |
@manics Is there a situation where order is relevant? Should we just make remove take the first matching element from the end of the list instead of the beginning? Or do we even need to offer more control (e.g. prepend, remove-last)? |
@knabar No, it was just a comment (c.f. the one from an earlier PR about empty vs [] being symmetric), I'm happy with the current behacviour. |
@will-moore / @dpwrussell : comments? |
Looks good! |
Merging. Leave guidelines for reworking the CI jobs to you, @sbesson. |
…ev_5_0 dev_5_0: Add omero config append/remove subcommands with default value handling for omero.web.* variables
This PR addresses https://trac.openmicroscopy.org.uk/ome/ticket/11201
Changes included are:
addition of bin/omero config append and bin/omero config remove so that configuration using lists of strings can easily be manipulated, e.g.
addition of corresponding unit tests under test_prefs.py
loading the default value from omeroweb/settings.py when a value is appended to or removed from a previously unset omero.web.* property.
--rebased-from #2030