Delete examples 11930 #2047
Merged
Delete examples 11930 #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the Java and the Python files against OMERO.server-5.0.0-rc1-306-77e3fe7-ice35-b205. Both delete functions completed successfully. Ready to merge. |
| doall.requests = dcs | ||
| handle = s.submit(doall) | ||
|
|
||
| callback = omero.callbacks.CmdCallbackI(c, handle) |
There was a problem hiding this comment.
The callback is not closed in a finally which will lead to resource exhaustion.
|
@joshmoore Won't be in today's build, but how does that look? |
|
Tested on gretzky: Thanks, @will-moore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated delete examples - see https://trac.openmicroscopy.org.uk/ome/ticket/11930
To test, run the Java and Python examples.
--rebased-to #2078