32 to 64 bit service API changes for binary data #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included in the port is a new safeLongToInteger() static method which will be universally responsible for safely converting Long to Integer in the context of the Romio I/O infrastructure. The method throws an ApiUsageException when there would be an overflow or an underflow caused by the downcast.
This port is the upcasting of sizeX * sizeY in the context of calculating whether or not a pyramid is required for the Pixels set in question. Without this change we have an integer overflow and images that require a pyramid are not assigned one and the client is confused, asking for whole plane rendering where the total number of pixels are on the gigabyte scale.
Conflicts: etc/omero.properties lib/repository/jai_imageio-362b9a2.jar lib/repository/loci-common-362b9a2.jar lib/repository/mdbtools-java-362b9a2.jar lib/repository/ome-io-17db504.jar lib/repository/ome-io-362b9a2.jar lib/repository/ome-io-c21c787.jar lib/repository/ome-xml-362b9a2.jar lib/repository/poi-loci-17db504.jar lib/repository/poi-loci-362b9a2.jar lib/repository/poi-loci-c21c787.jar
Conflicts: components/insight/LIB/ome-io.jar components/romio/ivy.xml components/server/src/ome/services/RawPixelsBean.java etc/omero.properties lib/repository/ome-io-17db504.jar lib/repository/ome-io-362b9a2.jar lib/repository/poi-loci-362b9a2.jar
|
This branch spent yesterday merged in with no ill-effects. Merging. |
joshmoore
added a commit
that referenced
this pull request
Jun 26, 2012
32 to 64 bit service API changes for binary data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where binary data has the possibility that multiplication can cause an integer overflow we have now upgraded to
longfromint.