Renamed Cut,Copy,Paste,Unlink options (see trac #11880) #2133
Conversation
|
Can update copyrights in source file headers to include 2014. |
|
All looks OK here. The only nitpick I'd have (doesn't have to be handled in this PR) is that the new "Cut Link" etc. taxonomy also now applies to the user management tab. Won't this be too confusing? |
|
@dominikl: the user section should be handled in that PR. |
| private static final String DESCRIPTION_COPY_LINK = | ||
| "Copy the selected links."; | ||
|
|
||
| /** Alternative description of the action if the index is {@link #COPY}. */ |
There was a problem hiding this comment.
Can't comment on comment lines, so adding here - the copyright date will have to be changed in this file.
|
The functionality is better now - the user management tab uses different wording for the cut, copy and paste actions. I noticed that the tooltips differ though (applicable to both user management tab and data viewer tab) - a different text is displayed on the tab's icon bar and a different in the context menu: |
Updated copyright; Formated code to match CodeTemplate.java; Synchronized popup menu and tab bar tooltips;
|
All looks good now. Thanks for the changes, @dominikl. Good to merge. |
|
@gusferguson : any screenshot or similar issues that need to be discussed before merging this? |
|
@joshmoore - I have been out of the loop on this, so if Blazej is happy, I don't have any further input. |
|
@joshmoore, @gusferguson I have no outstanding comments left for this PR. |
|
Thanks, all! |
Renamed Cut,Copy,Paste,Unlink options (see trac #11880)
|
--rebased-to #2159 |
Renamed "Cut", "Copy" and "Paste" options to "Cut Link", "Copy Link" and "Paste Link" and adjusted tooltips accordingly (see trac #11881). Renamed the "Unlink" option for removing tags into "Remove" and adjusted tooltips (see trac #11884).