Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Image IDs to script when Wells selected. See #11835 #2138

Merged
merged 1 commit into from
Mar 10, 2014

Conversation

will-moore
Copy link
Member

Fixes https://trac.openmicroscopy.org.uk/ome/ticket/11835
When Wells are selected in HCS data and we launch a script that only takes Image IDs, we get the Image IDs from the wells and pass to script.

To test:

  • Select one or more wells
  • Launch script that takes Image IDs (E.g. Batch Image Export)
  • Check that IDs field is populated with correct Image IDs for the currently selected Field (and Data Type is "Image").
  • Check that a different Field gives different Image IDs in the script.

@jburel jburel added the develop label Mar 3, 2014
@gusferguson
Copy link

@will-moore

Tested using Trout user-3

Selected 4 wells from plate:
Image IDs = 14354,14376,14608,14613
Well IDs: 307512, 307507, 307253, 307275
URL link: http://trout.openmicroscopy.org/webclient/?show=well-307253|well-307275|well-307507|well-307512

Ran Batch Image Export script:
Data Type = Image
Correct image IDs show in script dialogue: 14354,14376,14608,14613
Downloaded images - see screenshot below.

Ran Combine Images script:
Data Type = Image
Correct Image IDs show in script dialogue: 14354,14376,14608,14613
Combined image created with message that it could not be attached - saved to orphaned - appears correct.

Ran Thumbnail figure script:
Gave error message:
Need to specify /?Image=1,2 or /?Dataset=1,2

Works as expected for Batch Image Export and Combine Images.
If issue with Thumbnail Figure is expected, then good to merge.

finder

@will-moore
Copy link
Member Author

I don't think that the Figure scripts with custom UI (Thumbnail Figure or Split-View Figure) need to work with SPW data. Requirement was from https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=7367.
Happy to merge as is.

@joshmoore
Copy link
Member

Merging then. If there's a need for some follow-up, speak up.

joshmoore added a commit that referenced this pull request Mar 10, 2014
Pass Image IDs to script when Wells selected. See #11835
@joshmoore joshmoore merged commit daeb1ba into ome:develop Mar 10, 2014
@will-moore
Copy link
Member Author

--rebased-to #2155

@will-moore will-moore deleted the wells_to_script_iIds_11835 branch March 11, 2014 14:04
@sbesson sbesson added this to the 5.1.0-m1 milestone Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants