Inplace import icon dev 5 0, 11970 (rebased onto develop) #2148

dominikl · 2014-03-06T09:18:45Z

This is the same as gh-2116 but rebased onto develop.

Insight: Added an icon indicating that an image is an in-place import http://trac.openmicroscopy.org.uk/ome/ticket/11970

To test:

Select a regular imported image: The inplace-import-icon should not be shown in the metadata view
Select an inplace imported image: The inplace-import-icon should be shown like it was proposed in the regarding google document ( https://docs.google.com/document/d/1ZqJD0oyVOl5pnZR6w97PrskWM5U2C6QrrxNnPTyH4rk )

dominikl · 2014-03-06T09:18:46Z

--rebased-from #2116

pwalczysko · 2014-03-07T16:22:29Z

Having some problems with in-place import of couple of screenslhots on trout (possibly not connected with this PR):

2014-03-07 16:21:03,597 5210       [      main] ERROR  .importer.transfers.HardlinkFileTransfer - transfer process returned 1
2014-03-07 16:21:03,671 5284       [      main] ERROR     ome.formats.importer.cli.ErrorHandler - FILE_EXCEPTION: /homes/pwalczysko/petr-data/Screen Shot 2013-08-27 at 13.59.14.png
java.lang.RuntimeException: transfer process returned 1
    at ome.formats.importer.transfers.AbstractExecFileTransfer.exec(AbstractExecFileTransfer.java:137) ~[blitz.jar:na]
    at ome.formats.importer.transfers.AbstractExecFileTransfer.transfer(AbstractExecFileTransfer.java:57) ~[blitz.jar:na]
    at ome.formats.importer.ImportLibrary.uploadFile(ImportLibrary.java:410) [blitz.jar:na]
    at ome.formats.importer.ImportLibrary.importImage(ImportLibrary.java:473) [blitz.jar:na]
    at ome.formats.importer.ImportLibrary.importCandidates(ImportLibrary.java:274) [blitz.jar:na]
    at ome.formats.importer.cli.CommandLineImporter.start(CommandLineImporter.java:218) [blitz.jar:na]
    at ome.formats.importer.cli.CommandLineImporter.main(CommandLineImporter.java:685) [blitz.jar:na]
2014-03-07 16:21:03,672 5285       [      main] ERROR        ome.formats.importer.ImportLibrary - Error on import
java.lang.RuntimeException: transfer process returned 1
    at ome.formats.importer.transfers.AbstractExecFileTransfer.exec(AbstractExecFileTransfer.java:137) ~[blitz.jar:na]
    at ome.formats.importer.transfers.AbstractExecFileTransfer.transfer(AbstractExecFileTransfer.java:57) ~[blitz.jar:na]
    at ome.formats.importer.ImportLibrary.uploadFile(ImportLibrary.java:410) ~[blitz.jar:na]
    at ome.formats.importer.ImportLibrary.importImage(ImportLibrary.java:473) ~[blitz.jar:na]
    at ome.formats.importer.ImportLibrary.importCandidates(ImportLibrary.java:274) ~[blitz.jar:na]
    at ome.formats.importer.cli.CommandLineImporter.start(CommandLineImporter.java:218) [blitz.jar:na]
    at ome.formats.importer.cli.CommandLineImporter.main(CommandLineImporter.java:685) [blitz.jar:na]
2014-03-07 16:21:03,672 5285       [      main] INFO         ome.formats.importer.ImportLibrary - Exiting on error
[pwalczysko@ome-c6100-3 OMERO-CURRENT]$

pwalczysko · 2014-03-07T16:24:55Z

All the attempts to in-place import to trout ended like the above. Also plates, whole folder, single images, both ln_s and ln. Not able to in-place import to trout.

joshmoore · 2014-03-07T16:33:08Z

The above is due to the difference between /home/hudson (local) and /homes/pwalczysko (mounted). Currently being looked into.

pwalczysko · 2014-03-07T17:29:26Z

Further problem: inability to really import any plates to trout (be it in-place or not). Also when trying via client, the result is the same. The plate just does not appear in Insight, although the cmd line output does not show breaks. This is being investigated by @melissalinkert and @joshmoore .

he correct reader is being used server-side, but no plates or wells are being registered at all....
17:23 /repositories/OMERO-5.1-merge-deploy/ManagedRepository/user-1_8/2014-03/07/17-10-57.056.log for reference.

Tested formats with this behaviour:

bd-pathway
cellworx
flex

pwalczysko · 2014-03-07T17:34:07Z

Tested the Project/Dataset/Image data - all works as expected in the sense of this PR. As indicated above, could not test plates.

Nevertheless (sorry, @dominikl for not noticing this already in 5.0.0) - there is no way a user can read the content of the tooltip on the In-place icon before it vanishes. I actually still did not read to the end, because the text is long, and am not sure what does it actually say.

pwalczysko · 2014-03-07T17:37:19Z

Now I have read to the end of the tooltip, after trying 6-7 times to read really really quickly. The most important information is unfortunately at the bottom of the tooltip. Also, as you are using the sign for the icon of the Show file path feature, it is quite hard to decipher this, because it is not a usual sign, but icon, which is being drowned in the text. No way a user would find anything via this tooltip I am afraid.

dominikl · 2014-03-09T20:43:43Z

Tooltip text is as stated in the google doc. So revert PR and return to discussion?
https://docs.google.com/document/d/1ZqJD0oyVOl5pnZR6w97PrskWM5U2C6QrrxNnPTyH4rk/

pwalczysko · 2014-03-10T14:18:37Z

The main problem here is that the tooltip stays visible only so shortly. If this can be relieved easily, then I would do so. Otherwise probably need to return to discussion as suggested by @dominikl - but have nothing against merging this PR, it improves things I think - it is just that it was not envisaged that the tooltip is so intermittent. Opinion, @gusferguson ?

gusferguson · 2014-03-10T14:29:49Z

@dominikl @pwalczysko - the tooltip text in the scoping was still up for discussion. As I don't think users will have any mental model of what an in-place import is, I am at a loss as to what should be in the tooltip. Colin made some suggestions on modifying the tooltip text (comment in the GDoc) but I would say put it out for consultation - at the risk that the ensuing committee decision will make it even worse!
I will have a think about it.

gusferguson · 2014-03-10T14:36:25Z

@dominikl @pwalczysko
Suggestion:
In-place import - the file may not be located within the OMERO data directory. Click the file path button to see it's location.

pwalczysko · 2014-03-10T14:40:03Z

@gusferguson There is the problem of what to really put in. But another problem is that you have 2-3 seconds to read the text in the tooltip, before it vanishes… - the above is too long for that unfortunately as well (although I like it as a text when reading it here in peace on github)

pwalczysko · 2014-03-10T14:44:43Z

Thinking about this further, I actually think this text simply should not be a tooltip - it should be a popup window just like the Show file path button. Then it will stay long enough, and we can put the path there as well, instead of referring the user to yet another button - I know that this is muddying the water a bit, but the tooltip is really exasperating when you cannot read it.

mtbc · 2014-03-10T14:46:19Z

Good idea, as also it is nice to be able to copy and paste from that kind of thing.

gusferguson · 2014-03-10T14:47:00Z

Good idea - I would go with that as it will allow us to put the path in and use as much explanation as necessary.

dominikl · 2014-03-10T14:51:17Z

Ok!

dominikl · 2014-03-10T15:01:46Z

Well, the problem with the popup window is, it stays open. I guess that's a bit weird behaviour, if the user runs over the icon with the cursor and a popup window opens, which doesn't close automatically. If a window like thing opens without explicitly clicking on a button I'd expect it to vanish automatically again.
If staying with the tooltip there would also be the possibility to increase the duration it's shown (default timeout is 4 sec); usually this affects all tooltips in general, but with a bit a hack it's possible to just increase the timeout for this specific tooltip.

pwalczysko · 2014-03-10T15:07:05Z

Popup mini-menu - saying Show info or anything else, thus encouraging the user to click on it ? (just like it is in Show file path icon)

pwalczysko · 2014-03-10T15:07:29Z

Happy with the long-stay tooltip as well though.

joshmoore · 2014-03-10T20:23:52Z

@dominikl : are you implementing these via this PR? Or a new round of 2 PRs?

jburel · 2014-03-10T21:06:08Z

Since it is a rebase, I will go for another PR. this can fix while working on the Show path ticket

dominikl · 2014-03-11T08:56:07Z

Ok, I'll implement it in the scope of the "Show path" PR.

…-icon-dev_5_0 Inplace import icon dev 5 0, 11970 (rebased onto develop)

dominikl added 7 commits March 6, 2014 09:18

Added icon for inplace imports to metadata agent's IconManager

180d792

Added inplace import icon to metadata view

3fe41ba

Check if symlinks exist.

e884a3e

Removed an unnecessary import

e365b72

Added file transfer namespace constant to AnnotationData

e7c510a

Implemented transfer link check

01c0a1d

Added missing comment for setTransferLinks() method

0e7f860

dominikl restored the rebased/develop/inplace-import-icon-dev_5_0 branch March 6, 2014 09:18

dominikl mentioned this pull request Mar 6, 2014

Inplace import icon dev 5 0, 11970 #2116

Merged

jburel added the develop label Mar 6, 2014

joshmoore added a commit that referenced this pull request Mar 11, 2014

Merge pull request #2148 from dominikl/rebased/develop/inplace-import…

6d2c73b

…-icon-dev_5_0 Inplace import icon dev 5 0, 11970 (rebased onto develop)

joshmoore merged commit 6d2c73b into ome:develop Mar 11, 2014

dominikl mentioned this pull request Mar 13, 2014

Inplace file path #2165

Merged

dominikl deleted the rebased/develop/inplace-import-icon-dev_5_0 branch April 8, 2014 09:06

dominikl mentioned this pull request Apr 17, 2014

Inplace file path (rebased onto dev_5_0) #2323

Merged

sbesson added this to the 5.1.0-m1 milestone Oct 14, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inplace import icon dev 5 0, 11970 (rebased onto develop) #2148

Inplace import icon dev 5 0, 11970 (rebased onto develop) #2148

dominikl commented Mar 6, 2014

dominikl commented Mar 6, 2014

pwalczysko commented Mar 7, 2014

pwalczysko commented Mar 7, 2014

joshmoore commented Mar 7, 2014

pwalczysko commented Mar 7, 2014

pwalczysko commented Mar 7, 2014

pwalczysko commented Mar 7, 2014

dominikl commented Mar 9, 2014

pwalczysko commented Mar 10, 2014

gusferguson commented Mar 10, 2014

gusferguson commented Mar 10, 2014

pwalczysko commented Mar 10, 2014

pwalczysko commented Mar 10, 2014

mtbc commented Mar 10, 2014

gusferguson commented Mar 10, 2014

dominikl commented Mar 10, 2014

dominikl commented Mar 10, 2014

pwalczysko commented Mar 10, 2014

pwalczysko commented Mar 10, 2014

joshmoore commented Mar 10, 2014

jburel commented Mar 10, 2014

dominikl commented Mar 11, 2014

Inplace import icon dev 5 0, 11970 (rebased onto develop) #2148

Inplace import icon dev 5 0, 11970 (rebased onto develop) #2148

Conversation

dominikl commented Mar 6, 2014

dominikl commented Mar 6, 2014

pwalczysko commented Mar 7, 2014

pwalczysko commented Mar 7, 2014

joshmoore commented Mar 7, 2014

pwalczysko commented Mar 7, 2014

pwalczysko commented Mar 7, 2014

pwalczysko commented Mar 7, 2014

dominikl commented Mar 9, 2014

pwalczysko commented Mar 10, 2014

gusferguson commented Mar 10, 2014

gusferguson commented Mar 10, 2014

pwalczysko commented Mar 10, 2014

pwalczysko commented Mar 10, 2014

mtbc commented Mar 10, 2014

gusferguson commented Mar 10, 2014

dominikl commented Mar 10, 2014

dominikl commented Mar 10, 2014

pwalczysko commented Mar 10, 2014

pwalczysko commented Mar 10, 2014

joshmoore commented Mar 10, 2014

jburel commented Mar 10, 2014

dominikl commented Mar 11, 2014