Minify media viewer only

[atarkowska]

This PR replaced #2161. Created on top of #2194.
Those changes allows to embed image viewer on the static HTML website. All static files are minified using django-pipline and served on:

http://HOST/static/omeroweb.viewer.min.css
http://HOST/static/omeroweb.viewer.min.js

To test it remotely please go to https://github.com/aleksandra-tarkowska/openmicroscopy/tree/minify_media_viewer_only/components/tools/OmeroWeb/omeroweb/webtest/templates/webtest/embeding and download embedded.html. Then replace http://localhost in the following:

<link rel="stylesheet" type="text/css" href="http://localhost/static/omeroweb.viewer.min.css">
<script type="text/javascript" src="http://localhost/static/omeroweb.viewer.min.js"></script>

with the appropriate remote server name including custom prefix like http://remote_host/omero/

If you wish to test this PR locally you can use static page in webtest/templates/webtest/embed. Double click on the file and see if you can view image in the viewer.

In order to minify you need to run bin/omero web start that runs collectstatic command, your CSS and your javascripts will be compressed in the same time. If you run your development server directly you need to run python manage.py collectstatic first.

[will-moore]

The static webtest embed.html works fine locally.
Just for the record, there was a console error coming from the minified Raphael library but this has no effect on the viewer functionality (ROIs not shown).
TypeError: (intermediate value)(...) is not a function

Don't know if this actually breaks any potential use of Raphael or not?

[atarkowska]

Thanks @will-moore, that was a known issue. I would prefer to tackle Raphael library in the separate PR

[atarkowska]

@cneves ,@knabar, @manics, @dpwrussell would you like to make any comments on that PR?

[atarkowska]

@knabar looks like we do not need GZipMiddleware at all as it is used for HTML compression only, see https://github.com/cyberdelia/django-pipeline/blob/master/docs/usage.rst#middleware

[knabar]

@aleksandra-tarkowska Makes sense. That was the only thing that jumped out when I reviewed the code, I'll still run the changes on my local install to see if I can find anything else.

[atarkowska]

Great thanks

[knabar]

Some basic tests revealed no issues with this PR, although I found some other problems that were introduced some time ago (see PR #2205).

[atarkowska]

The latest develop has been merged inluding PR #2205

[atarkowska]

@knabar could you check whether we are missing anything else?

[knabar]

@aleksandra-tarkowska Everything else looks good

[chris-allan]

I'll give this a final once over today and add my comments.

[chris-allan]

If this is not needed it should be removed. If there's a reason it's commented out, that reason should be documented.

[atarkowska]

I have tested with and without ome.iehacks.css and I do not see any difference in IE9. I am not sure about usage of that as is only IE9 specific https://github.com/openmicroscopy/openmicroscopy/blob/develop/components/tools/OmeroWeb/omeroweb/webgateway/templates/webgateway/viewport/omero_image.html#L37. Removing that line for now

[chris-allan]

All looks great.

Other than the above comment my only other question is the addition of:

• components/tools/OmeroWeb/omeroweb/webgateway/static/3rdparty/jquery-ui-1.8.19/ui/minified/jquery-ui.min.js

This file was added in 9a6fb54.

Did you minify this yourself from ui/jquery-ui.js @aleksandra-tarkowska or is the minified file just from the 1.8.19 ZIP?

[atarkowska]

@chris-allan that is from jquery-ui package. I haven't minified anything else then omeroweb.viewer.min.css and omeroweb.viewer.min.js

[chris-allan]

Cool. Looks great to me. Ready to merge.

👍

[atarkowska]

--no-rebase